Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metric-stats): Add metric stats namespace #3267

Merged
merged 2 commits into from Mar 15, 2024
Merged

feat(metric-stats): Add metric stats namespace #3267

merged 2 commits into from Mar 15, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Mar 14, 2024

Adds the namespace, but it is still disabled, so we can make a librelay release for Sentry.

Epic: #3147

#skip-changelog

@Dav1dde Dav1dde requested a review from a team as a code owner March 14, 2024 13:50
@Dav1dde Dav1dde self-assigned this Mar 14, 2024
@Dav1dde Dav1dde mentioned this pull request Mar 14, 2024
Merged
olksdr
olksdr reviewed Mar 14, 2024
View reviewed changes
relay-base-schema/src/metrics/mri.rs Outdated Show resolved Hide resolved
relay-cogs/src/lib.rs Outdated Show resolved Hide resolved
olksdr
olksdr approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
In the followup I would like to see an integration test.

relay-base-schema/src/metrics/mri.rs Outdated Show resolved Hide resolved
@Dav1dde
Copy link
Member Author

Dav1dde commented Mar 15, 2024

In the followup I would like to see an integration test.

Will do, impossible now because the namespace is disabled.

@Dav1dde Dav1dde enabled auto-merge (squash) March 15, 2024 08:30
@Dav1dde Dav1dde merged commit 43bbb86 into master Mar 15, 2024
20 checks passed
@Dav1dde Dav1dde deleted the dav1d/metric_stats/namespace branch March 15, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olksdr olksdr olksdr approved these changes

Assignees

@Dav1dde Dav1dde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dav1dde @olksdr