Fix logic in find_dylib() and find_header() #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies if bumping this is poor form, but I ran into this same issue today. Could this be merged and published in a new version? Thanks! |
untitaker
reviewed
Jun 17, 2020
| if in_path is not None: | ||
| path = os.path.join(path, *in_path.split('/')) |
There was a problem hiding this comment.
@mitsuhiko why do we do this in the first place? What speaks against os.path.join(path, in_path)?
|
Is something blocking this PR from getting merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milksnake does not support searching for dylib/header in absolute directory.
It appends
pathto thein_pathvariable (if given): https://github.com/getsentry/milksnake/blob/ef0723e/milksnake/setuptools_ext.py#L146This prevent setting
CARGO_TARGET_DIRto an absolute path different of therust/subdirectory.This PR changes the logic so that appending happens only if
in_pathis not an absolute path. Also, thisin_pathis normalized as described in #24.Closes #24.