Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env var behaviour for cache removal. #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Env var behaviour for cache removal. #15

wants to merge 3 commits into from

Conversation

born2discover
Copy link

This fixes #6 and introduces a new environment variable "PLATFORM" which when defined and set to "DOKKU" would force the buildback not to perform the cache deletion command.
Otherwise if the env variable is not set, or set to "HEROKU" then that command will be performed.

For Dokku users it means adding an additional export statement in their .env file.

Example contents of .env file:

# Can be either DOKKU or any other string different from HEROKU.
export PLATFORM="DOKKU"
export BUILDPACK_URL=https://github.com/born2discover/heroku-buildpack-pelican

@julbrs
Copy link

julbrs commented Nov 2, 2017

+1 for this PR. Working very well on my dokku+pelican apps,

Thanks for the work,

@justinmayer
Copy link
Member

Any thoughts on this PR, @kylef?

@chadselph
Copy link

chadselph commented Jul 11, 2020

Looks like this never got merged :( and @born2discover removed their fork

@born2discover
Copy link
Author

Looks like this never got merged :( and @born2discover removed their fork

@chadselph : As I am not using this build-pack myself anymore I indeed have recently removed my fork. However the changes I proposed are still available on Github, just check the "Files changed" tab, so the proposed feature can still be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling the cache breaks push to Dokku
5 participants