Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim values stored in choices #752

Merged
merged 2 commits into from May 14, 2024
Merged

Trim values stored in choices #752

merged 2 commits into from May 14, 2024

Conversation

grzesiek2010
Copy link
Member

Closes #getodk/collect#5692

What has been done to verify that this works as intended?

I've added a new test and tested the form attached to getodk/collect#5692 manually.

Why is this the best possible solution? Were any other approaches considered?

There are multiple options when it comes to storing choices. They can be a part of a form file, they can be also stored in an external csv file using different mechanisms (the search/pulldata function, select_one_from_file/select_one_external question types). We don't want them to have values with redundant whitespace. The constructor is the common place used by all of the options so it seems to be the easiest way to make sure the values are trimmed no matter what option we use.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It's rather a safe change so testing the form from getodk/collect#5692 should be enough.

Do we need any specific form for testing your changes? If so, please attach one.

There is a form attached to getodk/collect#5692

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Copy link
Member

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a hard time thinking through possible consequences for this one for some reason! I do think it's the right thing to do. Let's get it in our beta and mention it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants