Fix potential ANR when saving form #6134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
approved these changes
May 15, 2024
|
@seadowg We don't have access to the firebase. Could you give us a hint how to try to reproduce it or what was it connected with? Was it on a specific Android version or a specific device? |
|
@dbemke sorry the testing notes were bad there. I've updated them. As a standing rule: PRs that fix ANR won't require checking that it no longer happens as they can't be reliably reproduced. We use Android tooling (StrictMode) to ensure they aren't possible any longer. The risk will usually be that a bug is introduced while fixing the ANR. |
|
Tested with Success! Verified on a device with Android 10 Verified Cases:
|
|
Tested with Success! Verified on a device with Android 14 |
|
Tested with Success! Verified on a device with Android 13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #5838
This removes UI thread DB access when showing a form saved snackbar.
Why is this the best possible solution? Were any other approaches considered?
Not a lot to discuss here! I've moved the DB access to a background thread which results in switching a single
getXmethod for asetXand aConsumable<LiveData>event.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Only thing affected here is the form saved snack bar, so some testing around that is all that is needed I'd imagine. Reproducing the ANR won't be possible (as always), so it's best just to check that nothing looks wrong with the existing feature set.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still pass