Automatically scroll when needed when clicking in tests #6092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
changed the title
seadowg
commented
Apr 12, 2024
| * because the click never actually occurs (most likely due to some flakiness in | ||
| * [androidx.test.espresso.action.ViewActions.click]). | ||
| */ | ||
| fun clickOn(view: Matcher<View>, root: Matcher<Root>? = null, assertion: () -> Unit) { |
There was a problem hiding this comment.
Using this helper is advisable over the other clickOn as it seems there's some flakiness in Espresso's ViewActions.click that are resolved with this "try again on fail" approach.
seadowg
changed the title
seadowg
commented
Apr 15, 2024
| } | ||
|
|
||
| fun clickManuallyEnterProjectDetails(): ManualProjectCreatorDialogPage { | ||
| scrollToAndClickText(org.odk.collect.strings.R.string.configure_manually) | ||
| return ManualProjectCreatorDialogPage().assertOnPage() | ||
| return clickOnString( |
There was a problem hiding this comment.
This change should resolve this flake.
grzesiek2010
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls out click interactions to a shared place and adds a fallback scroll when clicking fails so we don't need explicit methods for scrolling.