Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the regression test package #5983

Draft
wants to merge 43 commits into
base: master
Choose a base branch
from

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Feb 23, 2024

Why is this the best possible solution? Were any other approaches considered?

The regression package was a set of tests written by the QA team. It's been a while since the QA team added something there and we have decided that it will no longer be their responsibility.
I have reviewed the tests:

  • removing duplicated tests
  • reworking/moving test that we (developers) might still need
  • removing tests that didn't make much sense from my (dev) perspective or were difficult to understand.

The test cases that were covered by the tests I've removed are still performed manually by the QA team during regression testing I belive so it shouldn't be dangerous.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It doesn't require testing.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review February 23, 2024 20:27
@seadowg
Copy link
Member

seadowg commented Apr 15, 2024

@grzesiek2010 there's some conflicts here now (probably because of #6059 - sorry 😔).

Copy link
Member

@seadowg seadowg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grzesiek2010
Copy link
Member Author

@grzesiek2010 there's some conflicts here now (probably because of #6059 - sorry 😔).

Fixed.

@seadowg
Copy link
Member

seadowg commented Apr 26, 2024

Github doesn't let me track where I am in a review by commit so I'll just track it in this comment. Latest commit

@seadowg
Copy link
Member

seadowg commented May 20, 2024

I'm frankly finding it hard to find time to fit this in. @grzesiek2010 are you able just pull the commits after 74cbd26 onto another branch for the moment? I think this will be much easier to review and merge in chunks rather than all at once and there's no reason we need to make the change in one go.

@grzesiek2010
Copy link
Member Author

I'm frankly finding it hard to find time to fit this in. @grzesiek2010 are you able just pull the commits after 74cbd26 onto another branch for the moment? I think this will be much easier to review and merge in chunks rather than all at once and there's no reason we need to make the change in one go.

Let's keep this pr. I will convert it to a draft. There is a new one that contains the commits you have reviewed #6142

@grzesiek2010 grzesiek2010 marked this pull request as draft May 21, 2024 10:15
@seadowg seadowg removed their request for review May 21, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants