Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/integration: clean up hanging 'threads' #995

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alxndrsn
Copy link
Contributor

Resolves need for mocha's --exit flag, which the docs say:

enables a set of potential problems; it’s indicative of tests (or fixtures,
harnesses, code under test, etc.) which don’t clean up after themselves
properly. Ultimately, "dirty" tests can (but not always) lead to false
positive
or false negative results.

Flag originally introduced in:

Problems resolved:

  1. shut down db pool cleanly
  2. avoid yauzl streams in cases where they hang

Resolves need for mocha's `--exit` flag, which the docs say:

> enables a set of potential problems; it’s indicative of tests (or fixtures,
> harnesses, code under test, etc.) which don’t clean up after themselves
> properly. Ultimately, "dirty" tests can (but not always) lead to _false
> positive_ or _false negative_ results.

Flag originally introduced in:

* 472383e
* ca08b53

Problems resolved:

1. shut down db pool cleanly
2. clean up yauzl streams (by avoiding them?)
@alxndrsn
Copy link
Contributor Author

alxndrsn commented Sep 18, 2023

I think this indicates another subtle bug in streams, probably one of:

  • the cleanup code in test/util/zip.js, or
  • an unfulfilled interaction that supertest is expecting when working with streams, or
  • a bug in supertest's pipe/stream implementation

There's a very similar-looking issue filed at ladjs/supertest#487.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant