fixes 433: convert latin1 to utf for filenames return by multer #908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#433
Root cause:
Multer is parsing filename with latin1 encoding instead of UTF-8. expressjs/multer#1104
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
Created local middleware to convert latin1 encoding to utf8
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This is localized changed, if submission are tested from Enketo and Collect are tested then we should be good
Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.
None
Before submitting this PR, please make sure you have:
make test-full
and confirmed all checks still pass OR confirm CircleCI build passes