Possible typo in odata offset handling

[alxndrsn]

fiindIndex() looks like it should be findIndex()

[matthew-white]

Good catch, @alxndrsn! This does look like an issue to me. I confirmed that it can result in a user-facing error: getodk/central#622. In addition to fixing the typo, I think it'd be a good idea to write a test. There must not be a test that's hitting that function right now.

It could be that this usage pattern isn't common. I'd guess that a user is more likely to use $skiptoken to page through an entire repeat group (which hits rowStreamToOData()) rather than just the repeat group instances of an individual submission (singleRowToOData()). That said, I do think it'd be worth fixing this issue.

This is only sort of related, but what happens if the user specifies an invalid $skiptoken? It seems possible to me that findIndex() would return -1 if a submission edit causes the repeatId to no longer exist (if the edit removes the relevant repeat group instance). From a glance, I think the response would be successful and return data, but I don't think it should. I'd be happy to take a closer look at that once the main issue here is fixed.

@alxndrsn, are you interested in writing a test for this issue? We could also pass that off to me or @sadiqkhoja. I'm glad you made a note of this line!