Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support S3-compatible blob storage #1071

Open
wants to merge 449 commits into
base: master
Choose a base branch
from

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Jan 13, 2024

Closes getodk/central#585

Adds:

  • s3_status column on blobs table
  • CLI tool for:
    • uploading blobs to s3
    • resetting failed blobs -> pending

Changes:

  • blob.content uses must now be accompanied by a conditional fetch of the data from s3

Queries:

  • would it be preferable to make blob.content async everywhere, and moving the s3 check/fetch inside the getter?
    • pro: neater code, less likely to have bugs where blob.content used when data is not available
    • con: seems intrusive of frames
  • should "purging" forms in central also delete content from S3? yes

@alxndrsn alxndrsn changed the title Make it possible to configure S3-compatible blob storage Support S3-compatible blob storage May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store blobs outside database
2 participants