WIP: Syncing cli with server #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,15 +17,13 @@ CREATE TABLE "User" ( | |||
| "firstname" TEXT, | |||
| "lastname" TEXT, | |||
There was a problem hiding this comment.
I noticed all the good apps are using a single field for name. Like Figma, etc.
Then I remembered that asking for first name and last name has other issues as well:
- In some countries the first name is actually the last name, like in China
- When searching by full names we'll need joining them anyway
I suggest we go by a single field like Figma:
Name
There was a problem hiding this comment.
Fixed in #278, I will rebase this and drop related changes soon.
pouriaMaleki
force-pushed
the
feat/sync
branch
from
e84bbf2
to
3b28447
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.