Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Display invite links on the staff page #251

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

feat(ui): Display invite links on the staff page #251

wants to merge 1 commit into from

Commits on Feb 2, 2022

  1. feat(ui): Display invite links on the staff page 

    This adds the invitation URL to the server response for invitations and
it then leverages that URL on the client.  The hope here is to address
issue getmeli#247 and ideally just make it easier to use Meli without having
to have a working email server to send out invites.

Design note: I very deliberately pass a URL back from the server
instead of just the bare token.  The reason is that if I pass back
a bare token then the UI will have to formulate the URL which
means duplicating that logic both client and server side which
I have a visceral dislike for (very bad code smell, IMHO).  This
way, only the server needs to know how to construct the URLs
and it can unilaterally change the scheme if it wants with
_zero_ impact on the client.  Hypermedia for the win.
    @mt35-rs
    mt35-rs committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    b5cf2d9 View commit details
    Browse the repository at this point in the history