Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for visibility timeout and content based deduplication #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andremonteiro95
Copy link

We have run into some use cases where we need to manually set the visibility timeout and turn off content-based duplication, as such, we had the need to configure these directly in the serverless.yml.

@fredericbarthelet
Copy link
Collaborator

Hi @andremonteiro95, we discussed this PR earlier with @mnapoli and we came up with the idea illustrated in #191.

Because we don't want every construct to turn into something with hundreds of options, but also we don't want to limit users. WDYT?

@andremonteiro95
Copy link
Author

Hi @fredericbarthelet, thanks for your reply.

I guess the first proposal is more in line with what Serverless already supports (resources.extensions).

Can you give me an example of how it would work with an SQS resource? I looked at the AWS Cloudformation Resource Reference table and I didn't find a reference for SQS, I don't know if you are relying on these.

@seantcanavan
Copy link
Contributor

seantcanavan commented Feb 16, 2023

@fredericbarthelet is there any documentation on how to disable content based deduplication with #191?

EDIT: The documentation is located here https://github.com/getlift/lift/blob/master/docs/queue.md#extensions and here's the relevant code snippet for anyone else coming from google / github search:

constructs:
    my-queue:
        type: queue
        worker:
            handler: src/worker.handler
        extensions:
            queue:
                Properties:
                    ContentBasedDeduplication: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants