Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect splitting when body contains delimiter #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rubenv
Copy link
Contributor

@rubenv rubenv commented Nov 29, 2018

When the body of a file contains a delimiter, incorrect parsing occurs.

I haven't yet found a good way to fix this (the use of SplitFunc makes it a bit difficult to reconstruct the original text and I have yet to figure out the best way to simply make it stop splitting), but for now here's a unit test to illustrate things.

@rubenv
Copy link
Contributor Author

rubenv commented Nov 29, 2018

Am thinking we'll need to change *Matter.split(), so that it only splits twice (once before front matter, once after). But to do that we'll need to keep track of the number of splits that have happened.

Sadly I see no way to do so without putting state into *Matter, which would break thread-safety.

@snipem
Copy link

snipem commented Apr 3, 2020

I found this to be a problem with an asciidoc file with a ditaa diagram containing --- lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants