New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEOS-11352] REST service for URL checks #7582
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The general infrastructure looks ok, but there is a fundamental API breakage in this PR that needs to be reverted.
src/main/src/main/java/org/geoserver/config/util/XStreamPersister.java
Outdated
Show resolved
Hide resolved
src/main/src/main/java/org/geoserver/security/urlchecks/AbstractURLCheck.java
Outdated
Show resolved
Hide resolved
src/main/src/main/java/org/geoserver/security/urlchecks/AbstractURLCheck.java
Outdated
Show resolved
Hide resolved
src/rest/src/main/java/org/geoserver/rest/RestControllerAdvice.java
Outdated
Show resolved
Hide resolved
src/restconfig/src/main/java/org/geoserver/rest/security/UrlCheckController.java
Outdated
Show resolved
Hide resolved
src/restconfig/src/main/java/org/geoserver/rest/security/UrlCheckController.java
Show resolved
Hide resolved
src/restconfig/src/test/java/org/geoserver/rest/security/UrlCheckControllerTest.java
Show resolved
Hide resolved
<execution> | ||
<id>generate-urlchecks-api</id> | ||
<goals> | ||
<goal>generate</goal> | ||
</goals> | ||
<configuration> | ||
<generatorName>java</generatorName> | ||
<inputSpec>${openapi-base-folder}/urlchecks.yaml</inputSpec> | ||
<configurationFile>${project.basedir}/client-api-config.json</configurationFile> | ||
<generateSupportingFiles>false</generateSupportingFiles> | ||
<generateModelTests>false</generateModelTests> | ||
<generateApiTests>false</generateApiTests> | ||
<generateApiDocumentation>false</generateApiDocumentation> | ||
<generateModelDocumentation>false</generateModelDocumentation> | ||
</configuration> | ||
</execution> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@groldan you're the maintainer of the rest-openapi module. Does this change look legit to you?
Adding a REST service to manage URL checks would be potentially beneficial to those users who want to use automated tools to set URL rules for external access in their GeoServer instances.
Checklist
main
branch (backports managed later; ignore for branch specific issues).For core and extension modules:
[GEOS-XYZWV] Title of the Jira ticket
.