Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOS-11352] REST service for URL checks #7582

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

axl8713
Copy link
Contributor

@axl8713 axl8713 commented Apr 26, 2024

GEOS-11352 Powered by Pull Request Badge

Adding a REST service to manage URL checks would be potentially beneficial to those users who want to use automated tools to set URL rules for external access in their GeoServer instances.

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

Copy link
Member

@aaime aaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general infrastructure looks ok, but there is a fundamental API breakage in this PR that needs to be reverted.

doc/en/api/1.0.0/urlchecks.yaml Show resolved Hide resolved
doc/en/user/source/rest/urlchecks.rst Outdated Show resolved Hide resolved
Comment on lines +265 to +280
<execution>
<id>generate-urlchecks-api</id>
<goals>
<goal>generate</goal>
</goals>
<configuration>
<generatorName>java</generatorName>
<inputSpec>${openapi-base-folder}/urlchecks.yaml</inputSpec>
<configurationFile>${project.basedir}/client-api-config.json</configurationFile>
<generateSupportingFiles>false</generateSupportingFiles>
<generateModelTests>false</generateModelTests>
<generateApiTests>false</generateApiTests>
<generateApiDocumentation>false</generateApiDocumentation>
<generateModelDocumentation>false</generateModelDocumentation>
</configuration>
</execution>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@groldan you're the maintainer of the rest-openapi module. Does this change look legit to you?

@axl8713 axl8713 requested a review from aaime May 10, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants