Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade maven-pmd-plugin to 3.22.0 which uses PMD 7 by default #7577

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

mprins
Copy link
Member

@mprins mprins commented Apr 25, 2024

This upgrades to the current release of the maven-pmd-plugin which uses PMD 7.0.0 by default.
While at it also update the build steps in the GH workflow
In 7.0.0 some rules have changed, this requires some changes in the selected rules.
As a result some PMD warnings are now triggered that need fixing.

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

@mprins mprins self-assigned this Apr 25, 2024
…EmptyIfStmt, EmptyInitializer, EmptyStatementBlock, EmptySwitchStatements, EmptySynchronizedBlock, EmptyTryBlock, and EmptyWhileStmt
@mprins mprins force-pushed the upgrade_m-pmd-p branch 3 times, most recently from f5d5d32 to 3036b99 Compare April 25, 2024 15:33
@aaime
Copy link
Member

aaime commented Apr 26, 2024

Nice one! Ambitious, too 🤣
I'll see if I can help, but can't promise anything in the short term.

@mprins
Copy link
Member Author

mprins commented Apr 26, 2024

This turns out to be much more work than anticipated, unfortunately I've no run out of time due to upcoming holiday, so this PR will stall from my side for a couple of weeks. Anyone willing to spend some time on it is quite welcome 🤣

@aaime
Copy link
Member

aaime commented May 4, 2024

Migrated a couple of modules while I was travelling.

@aaime
Copy link
Member

aaime commented May 4, 2024

And a few more under "web" (but not all yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants