Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOS-11370] Refactor inline JavaScript in the TestWfsPost Page #7554

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sikeoka
Copy link
Contributor

@sikeoka sikeoka commented Apr 18, 2024

GEOS-11370 Powered by Pull Request Badge

This PR moves the inline JavaScript in the TestWfsPost HTML page into an external file. This PR is related to Content-Security-Policy work for GeoServer 2.26.0 and should NOT be backported.

The new webresources path is intended to be reused which is why it was put in gs-main. The additional HTML escaping isn't really necessary but is a good practice.

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

Copy link
Contributor

@petersmythe petersmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging conflict manually in GitHub IDE

Copy link
Contributor

@petersmythe petersmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I built & tested it locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants