[GEOS-11369] Additional authentication options for cascaded WMS|WMTS data stores

[petersmythe]

Unlike cascaded WMTS stores, WMS stores do not have the option to pass an HTTP header along with the request (for authentication purposes):

This PR, in conjunction with GeoTools PR, fixes that.

I am also considering another field for a querystring API key/authkey, for both WMS and WMTS stores.

Related

This PR is to be merged concurrently with:

• [GEOT-7557] Provide the ability for downstream applications (e.g. GeoServer) to append additional querystring parameters e.g. AuthKey to every request made by the HTTPClient geotools/geotools#4727

Checklist

• I have read the contribution guidelines.
• I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
• First PR targets the main branch (backports managed later; ignore for branch specific issues).
• All the build checks are green (see automated QA checks).

For core and extension modules:

• New unit tests have been added covering the changes.
• Documentation has been updated (if change is visible to end users).
• The REST API docs have been updated (when changing configuration objects or the REST controllers).
• There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
• Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
• Bug fixes and small new features are presented as a single commit.
• Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

[petersmythe]

Tests are failing because it relies on GeoTools PR to be committed first

[petersmythe]

Tests are failing because it relies on GeoTools PR to be committed first

[jodygarnett]

This PR looks good thank you for the improvement :)

I have a question about a single header name / value pair being supported; it seems inconsistent with code comments.

[petersmythe]

Merging with geotools/geotools#4727

[aaime]

Merging, the lack of coordination between geotools and GeoServer is breaking several builds and workflows (two people already mentioned it to me). When you do coordinates PRs, please make sure to merge them toghether.

[sikeoka]

FYI, this PR is failing the QA build:

15:47:21,974 [INFO] --- pmd:3.14.0:check (default) @ gs-main ---
15:47:21,977 [INFO] PMD version: 6.42.0
15:47:21,978 [INFO] PMD Failure: org.geoserver.catalog.WMSStoreInfo:40 Rule:MissingOverride Priority:3 The method 'getAuthKey()' is missing an @Override annotation..
15:47:21,978 [INFO] PMD Failure: org.geoserver.catalog.WMSStoreInfo:42 Rule:MissingOverride Priority:3 The method 'setAuthKey(String)' is missing an @Override annotation..
15:47:21,978 [INFO] PMD Failure: org.geoserver.catalog.WMTSStoreInfo:40 Rule:MissingOverride Priority:3 The method 'getAuthKey()' is missing an @Override annotation..
15:47:21,978 [INFO] PMD Failure: org.geoserver.catalog.WMTSStoreInfo:42 Rule:MissingOverride Priority:3 The method 'setAuthKey(String)' is missing an @Override annotation..
15:47:21,978 [INFO] PMD Failure: org.geoserver.catalog.WMSStoreInfo:40 Rule:MissingOverride Priority:3 The method 'getAuthKey()' is missing an @Override annotation..
15:47:21,978 [INFO] PMD Failure: org.geoserver.catalog.WMSStoreInfo:42 Rule:MissingOverride Priority:3 The method 'setAuthKey(String)' is missing an @Override annotation..
15:47:21,978 [INFO] PMD Failure: org.geoserver.catalog.WMTSStoreInfo:40 Rule:MissingOverride Priority:3 The method 'getAuthKey()' is missing an @Override annotation..
15:47:21,978 [INFO] PMD Failure: org.geoserver.catalog.WMTSStoreInfo:42 Rule:MissingOverride Priority:3 The method 'setAuthKey(String)' is missing an @Override annotation..

[petersmythe]

Yes @sikeoka , I am also noticing that the GeoServer build is failing, which is why I delayed merging GeoServer @aaime , I will investigate now

[petersmythe]

Fixed now with #7589