Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.22.x][GEOS-10682+GEOS10680] GeoFence refactoring and WPS improvements #6569

Closed
wants to merge 2 commits into from

Conversation

etj
Copy link
Member

@etj etj commented Feb 3, 2023

GEOS-10682

GEOS-10680

Backport of #6227. Copying original description below:


This PR includes also:

It needs:

Changes in this PR:

  • Add a new maven module repo src/extensions/geofence, moving the existing geofence and geofence-server under it
  • Add a new maven module src/extensions/geofence/geofence-wps; since both geofence and wps are optional extensions, geofence-wps is a bridge module that allows geofence to get info created inside the wps module.
  • Add the WPS checks for process+data
  • Handles the new field subfield (#226 Add subfield field geofence#227)
    • filtering
    • rest
    • wicket
  • Some refactoring of util classes/methods
  • Fixes some requests by replacing ANY with DEFAULT

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

# Conflicts:
#	src/extension/geofence-server/src/test/resources/org/geoserver/geofence/server/integration/lakes_and_places_full.png
@aaime
Copy link
Member

aaime commented Feb 6, 2023

Big backport. Did you ask permission to perform it, elaborating on why/how it can't cause regressions for existing installations upgrading within the stable series? (e.g., inside 2.22.x)

@etj etj marked this pull request as draft February 6, 2023 10:26
@etj
Copy link
Member Author

etj commented Feb 6, 2023

Converting to draft in order to have some more time to perform deeper tests before requesting to merge.

@stale
Copy link

stale bot commented May 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 7, 2023
@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically closed because it has not had recent activity. Please re-submit with updates if you want to resume work on this topic. Thank you for your contributions.

@stale stale bot closed this May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants