Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add renovate bot #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

buehner
Copy link
Member

@buehner buehner commented Feb 9, 2024

This introduces a renovate bot configuration and enables a scheduled github action that checks for dependency updates on all levels (github actions, docker base images). Renovate will then create pull requests whenever it detects new versions. Especially, this leads to the use of explicit docker image digests in the Dockerfile. This is an essential preparation for the suggestions made in GEOS-11231.

We tested this in a forked repo. Here is an example output: buehner#5

Note: This does not produce auto-merges, but instead provides a helpful overview on base images that can be updated.

However: To get this running, a github secret named RENOVATE_TOKEN is required. The content of this secret is a personal github access token (classic) with the following scopes: repo (all) and workflow. As we do not have sufficient rights to create such a secret/token, it would be great if one of you could prepare this and let us know here @jodygarnett @aaime

Regarding GEOS-11231 we could then think about triggering a jenkins job to recreate the geoserver docker images based on the updated base images. The docker tags would not change, but by using explicit digests it would still be possible to use older images.

Pseudo example:

curl https://build.geoserver.org/job/JOB_NAME/buildWithParameters \
--user USER:TOKEN \
--data id=123 --data verbosity=high

buehner and others added 2 commits February 9, 2024 14:24
Co-authored-by: Andreas Schmitz <schmitz@terrestris.de>
Co-authored-by: André Henn <henn@terrestris.de>
@mprins
Copy link
Member

mprins commented Feb 20, 2024

this won't catch updating tomcat as it is specified as a build argument

@buehner
Copy link
Member Author

buehner commented Feb 20, 2024

@mprins looking at this change it could be possible renovatebot/renovate#15751 ?

I just had a very quick look, but I will give it a try locally/in my repo as soon as I find some time.

@buehner
Copy link
Member Author

buehner commented Feb 20, 2024

Ahh, got it now. We currently do not use the tomcat version in a FROM statement. But this would be "solved" by #45 i guess...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants