New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore dry deposition output in GCHP & GCClassic fullchem benchmark simulations #2144
base: dev/14.4.0
Are you sure you want to change the base?
Conversation
run/GCClassic/HISTORY.rc.templates/HISTORY.rc.fullchem - Change ##'DryDep' -> #'DryDep', which will activate this collection in benchmark simulations. run/GCHP/HISTORY.rc.templates/HISTORY.rc.fullchem - Change @#'DryDep' -> #'DryDep', which will activate this collection in benchmark simulations. - Also reduce the DryDep collection species to only those species we need for benchmark plots/tables CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
I left the base branch as main so that this PR wouldn't auto-close when dev/14.3.0 was removed. This can go into the dev/14.4.0 branch once we start working on it. |
Do we need to turn on dry deposition diagnostics for GCHP and GC-Classic fullchem benchmarks by default? I think the dry dep diagnostics are only needed for 1-year benchmarks. |
That's correct, I think. The setup script I have for GCClassic 1-year benchmark uncomments the DryDep (and other) diagnostics in HISTORY.rc. We could set up a similar script for GCHP. |
Alternatively, we could activate the drydep plots (for a subset of species) in 1-month benchmarks. It might be useful to diagnose changes there as well. @yantosca any thoughts? |
Yes, I was thinking we could activate a subset of species for the 1-month as well. That way we can detect any changes caused by LAI updates etc. |
This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue. |
@yantosca What is the status of this PR? Should it be included in 14.4.0? |
@msulprizio: It could go into 14.4.0. We'd need to doublecheck the HISTORY.rc files and maybe also make a corresponding update in the GCPy template YAML files though. I haven't had time to work on this lately but we could try to get it in before the 14.4.0 freeze date. |
It looks like integration tests should be able to test out the HISTORY.rc file changes, and the GCPy updates could go in later, whenever we decide to add drydep plots to the benchmark. I updated the milestone to be 14.4.0. |
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
This is the companion PR to #2139. We have updated the template
HISTORY.rc.fullchem
files for both GCHP and GCClassic so as to activate theDryDep
collection in benchmark simulations. Also, for the GCHP simulation, we have reduced the number of species output to netCDF to only those that are absolutely needed for the benchmarks (as described in #2135).Expected changes
This PR will activate dry deposition output for full-chemistry benchmark simulations, so that plots of dry deposition velocity can be made. Also the dry-deposition flux of O3 will be archived so as to be able to compute the Ox budget.
Related Github Issue(s)