Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trigger CI on changes to sample data #139

Merged
merged 1 commit into from Jun 25, 2023
Merged

trigger CI on changes to sample data #139

merged 1 commit into from Jun 25, 2023

Conversation

tomkralidis
Copy link
Member

No description provided.

@tomkralidis tomkralidis merged commit 90d8bf3 into master Jun 25, 2023
1 check passed
@tomkralidis tomkralidis deleted the ci-data branch June 25, 2023 15:53
@justb4
Copy link
Member

justb4 commented Jun 25, 2023

There is no need for this: the Dockerfile does not include any content: no Notebooks, no data:
https://github.com/geopython/geopython-workshop/blob/master/workshop/jupyter/Dockerfile

In the docker-compose.yml the entire content dir, thus alsocontent/data is mounted into the running Container:
https://github.com/geopython/geopython-workshop/blob/master/workshop/docker-compose.yml#L10.

tomkralidis added a commit that referenced this pull request Jun 25, 2023
@tomkralidis
Revert "trigger CI on changes to sample data (#139)"
db8ab96 
This reverts commit 90d8bf3.
@tomkralidis
Copy link
Member Author

Reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalxas kalxas kalxas approved these changes

@justb4 justb4 Awaiting requested review from justb4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomkralidis @justb4 @kalxas