New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First draft of a MVP gRPC API for the GEOPM Runtime #3362

Draft

cmcantalupo wants to merge 50 commits into geopm:dev from cmcantalupo:runtime-service

Contributor

cmcantalupo commented Feb 28, 2024 •

edited

This is a proposal for a GEOPM Runtime Service API which enables remote control and sampling of optimization algorithms over TCP/IP. The PoC and protobuffer definition is posted here.

The runtime.py script which is an example client code that uses the service to populate a database with energy and power information gathered from the compute node. This serves as an example use case, and will likely change over time.

Adding a gRPC service that supports some of the features of the GEOPM runtime
WIP: this is a proof of concept and not ready to be merged
Feedback is welcome, but the implementation is incomplete

cmcantalupo force-pushed the runtime-service branch 4 times, most recently from 2e82dc2 to 2f68e75 Compare

February 29, 2024 20:56

bgeltz reviewed

View reviewed changes

geopm_runtime.proto Outdated Show resolved Hide resolved

cmcantalupo force-pushed the runtime-service branch from 04b2546 to e8e1baa Compare

March 11, 2024 16:20

cmcantalupo commented

View reviewed changes

geopm_runtime.proto Outdated Show resolved Hide resolved

cmcantalupo commented

View reviewed changes

geopm_runtime.proto Outdated Show resolved Hide resolved

cmcantalupo commented

View reviewed changes

geopm_runtime.proto Outdated Show resolved Hide resolved

cmcantalupo commented

View reviewed changes

geopm_runtime.proto Outdated Show resolved Hide resolved

cmcantalupo commented

View reviewed changes

geopm_runtime.proto Outdated Show resolved Hide resolved

bgeltz reviewed

View reviewed changes

geopm_runtime.proto Outdated Show resolved Hide resolved

cmcantalupo force-pushed the runtime-service branch from 17cb343 to 6cd5b30 Compare

March 13, 2024 15:35

cmcantalupo commented

View reviewed changes

src/RuntimeService.hpp Outdated Show resolved Hide resolved

cmcantalupo commented

View reviewed changes

geopm_runtime.proto Outdated Show resolved Hide resolved

cmcantalupo commented

View reviewed changes

scripts/geopmpy/runtime.py Outdated Show resolved Hide resolved

cmcantalupo mentioned this pull request

Develop prototype code for gRPC Runtime Service #3373

Closed

2 tasks

cmcantalupo and others added 13 commits

March 21, 2024 13:29


          Allow push_signal/control() for previous requests after read/write_ba…

86d3caa

…tch()

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          First draft of a MVP gRPC API for the GEOPM Runtime

3562cc0

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Avoid exposing GEOPM PlatformIO concepts directly

18deb7d

- Also make reports a strict function of the "agent" selected.

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Add first/last rather than just latest

4f2b3a2

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Add missing semis

02397f7

Co-authored-by: Brad Geltz <brgeltz@gmail.com>


          Refine APIs

fa86522

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Leave room for non-linear LSE in the future

cff78b1

- These are least squqres estimates regressing against time
- May want quadratic or cubic LSE regressions in the future

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Add protobuffers to runtime build

46f07c0

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Add an empty implementation of the gRPC callbacks

5dd53b1

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Simplify protobuffer definition

963e728

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Simplify API further

ab92293

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Start to fill in implementation for runtime service

3dd25fc

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          fixup build

4b6eff2

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>

cmcantalupo added 20 commits

March 21, 2024 13:29


          Add python client grpc bindings

09695a1

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>

wip

8815fa7

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Get rid of pthread call

7debd3a

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Create both python bindings

a6daf2b

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Add geopmrt command line tool client for the geopmrtd

e4dec51

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Debuging, still seeing all nan reports

ae45f35

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Fixup issues found in debug

d151eee

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Add GPU signals unconditionally (papers over issue with missing signals)

c0543f6

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          fixup gitignore

62241c9

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Fill in the rest of the report data

11de73e

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Add sqlite db backend

43a2403

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Get rid of new calls

6b68947

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Change return values for adding and removing child hosts

c1e56f0

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Clean up database interface

c4a526e

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Add some doxygen comments and fix shabang

bdbe1ca

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          fixup

ffef1f6

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Make report ids unique

a44f751

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Do not reset PlatformIO since batch server does not get reset

9b24ff7

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Stop the deamon from sampling when run completes

06d5caa

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Fixup race when agent is changed

3311b4c

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>

cmcantalupo force-pushed the runtime-service branch from 26366a2 to 3311b4c Compare

March 21, 2024 20:29

cmcantalupo mentioned this pull request

Allow push_signal/control() for previous requests after read/write_batch() #3377

Merged

cmcantalupo added 2 commits

March 21, 2024 17:41


          Clean up output start up data

28d11e6

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Provide full CLI for geopmrt

9e7b70b

- Add a script to run client and server on local host.

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>

cmcantalupo force-pushed the runtime-service branch from 2a8e665 to 9e7b70b Compare

March 22, 2024 16:42

cmcantalupo and others added 5 commits

March 22, 2024 14:54


          Switch time in report from uptime to canonical time

3319ade

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Clean up documentation

d55092c

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Add input error checks

28c71a1

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>


          Added web front-fend for geopmrt

b2dd80e


          Added rolling window to geopmrt web interface.

17bad9d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment