Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a frequency rebalancer agent #3062

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

dannosliwcd
Copy link
Contributor

This set of changes introduces the frequency_balancer agent, which adjusts for imbalance by assigning more CPU
frequency resources cores that spend less MPI time per epoch. The changes include integration tests that check for energy savings, and also for performance improvement if SST is available on the test system.

Copy link
Contributor

@bgeltz bgeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About halfway through my first pass. Still have to review everything under run_sst_evaluation_nas_bt.py.

.gitignore Outdated Show resolved Hide resolved
copying_headers/MANIFEST.EXEMPT Outdated Show resolved Hide resolved
integration/apps/apps.py Show resolved Hide resolved
integration/experiment/sst_evaluation/Makefile.mk Outdated Show resolved Hide resolved
integration/experiment/sst_evaluation/gen_plot_time.py Outdated Show resolved Hide resolved

from experiment.sst_evaluation import sst_evaluation
from experiment import machine
from apps.nasbt import nasbt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nasbt does not exist in dev, nor was it introduced in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #2926 should cover it. I'll try rebasing that one on the latest dev.

integration/experiment/sst_evaluation/sst_evaluation.py Outdated Show resolved Hide resolved
integration/test/test_frequency_balancer.py Outdated Show resolved Hide resolved
service/docs/source/geopm_agent_frequency_balancer.7.rst Outdated Show resolved Hide resolved
service/docs/source/geopm_agent_frequency_balancer.7.rst Outdated Show resolved Hide resolved
service/docs/source/geopm_agent_frequency_balancer.7.rst Outdated Show resolved Hide resolved
src/FrequencyBalancerAgent.cpp Outdated Show resolved Hide resolved
src/FrequencyBalancerAgent.cpp Outdated Show resolved Hide resolved
src/FrequencyBalancerAgent.cpp Outdated Show resolved Hide resolved
src/FrequencyBalancerAgent.cpp Outdated Show resolved Hide resolved
src/FrequencyBalancerAgent.cpp Outdated Show resolved Hide resolved
@dannosliwcd dannosliwcd self-assigned this Mar 25, 2024
@dannosliwcd dannosliwcd force-pushed the dcw/issue-2681-rebalancer branch 2 times, most recently from 29d6c85 to b246326 Compare April 26, 2024 22:28
dannosliwcd and others added 16 commits April 26, 2024 17:06
- Resolves geopm#2681
- Introduces an agent that adjusts for imbalance by assigning more CPU
  frequency resources cores that spend less MPI time per epoch.
- Agent supports control by P-States and/or SST core priorities.
- Resolves geopm#2682
- Add NAS-BT and AIB experiments
- Add a plot generator
- Resolves 2682
- Introduces an integration test that checks for energy savings when the
  frequency_balancer is used with P-State control in an imbalanced
  application. If SST is present on the test system, the test also
  checks for performance improvement.
Co-authored-by: Brad Geltz <brgeltz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants