-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a frequency rebalancer agent #3062
base: dev
Are you sure you want to change the base?
Conversation
50f409f
to
9943d84
Compare
2cd441d
to
0859ce3
Compare
9943d84
to
e041c05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About halfway through my first pass. Still have to review everything under run_sst_evaluation_nas_bt.py.
integration/experiment/sst_evaluation/run_sst_evaluation_arithmetic_intensity.py
Outdated
Show resolved
Hide resolved
|
||
from experiment.sst_evaluation import sst_evaluation | ||
from experiment import machine | ||
from apps.nasbt import nasbt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nasbt does not exist in dev, nor was it introduced in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think #2926 should cover it. I'll try rebasing that one on the latest dev.
29d6c85
to
b246326
Compare
- Resolves geopm#2681 - Introduces an agent that adjusts for imbalance by assigning more CPU frequency resources cores that spend less MPI time per epoch. - Agent supports control by P-States and/or SST core priorities.
- Resolves geopm#2682 - Add NAS-BT and AIB experiments - Add a plot generator
- Resolves 2682 - Introduces an integration test that checks for energy savings when the frequency_balancer is used with P-State control in an imbalanced application. If SST is present on the test system, the test also checks for performance improvement.
Co-authored-by: Brad Geltz <brgeltz@gmail.com>
b246326
to
7a7518d
Compare
This set of changes introduces the frequency_balancer agent, which adjusts for imbalance by assigning more CPU
frequency resources cores that spend less MPI time per epoch. The changes include integration tests that check for energy savings, and also for performance improvement if SST is available on the test system.