Added NodePowerGovernorAgent #2927
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhlawson
force-pushed
the
public-lhlawson-node-power-characterization
branch
5 times, most recently
from
2ba6fd8
to
460c234
Compare
lhlawson
commented
Apr 20, 2023
| , m_do_write_batch(false) | ||
| , m_last_power_budget(NAN) | ||
| , m_power_budget_changed(false) | ||
| , m_epoch_power_buf(geopm::make_unique<CircularBuffer<double> >(16)) // Magic number... |
There was a problem hiding this comment.
Magic taken straight from the existing power governor agent. If this is not needed for ongoing experiments we can remove it.
lhlawson
force-pushed
the
public-lhlawson-node-power-characterization
branch
5 times, most recently
from
85fee63
to
1594055
Compare
lhlawson
force-pushed
the
public-lhlawson-node-power-characterization
branch
from
1594055
to
537e6ff
Compare
Signed-off-by: lhlawson <lowren.h.lawson@intel.com>
lhlawson
force-pushed
the
public-lhlawson-node-power-characterization
branch
from
537e6ff
to
e01d219
Compare
dannosliwcd
reviewed
Aug 7, 2023
Comment on lines
+2
to
+3
| geopm::PowerGovernorAgent(3) -- agent that enforces a power cap | ||
| =============================================================== |
There was a problem hiding this comment.
Suggested change
| geopm::PowerGovernorAgent(3) -- agent that enforces a power cap | |
| =============================================================== | |
| geopm::NodePowerGovernorAgent(3) -- agent that enforces a node power cap | |
| ======================================================================== |
|
|
||
| #include `<geopm/NodePowerGovernorAgent.hpp> <https://github.com/geopm/geopm/blob/dev/src/NodePowerGovernorAgent.hpp>`_ | ||
|
|
||
| Link with ``-lgeopm`` **(MPI)** or ``-lgeopmpolicy`` **(non-MPI)** |
There was a problem hiding this comment.
I think geopmpolicy is gone now
dannosliwcd
reviewed
Aug 7, 2023
Comment on lines
+2
to
+3
| geopm_agent_power_governor(7) -- agent enforces a power cap | ||
| =========================================================== |
There was a problem hiding this comment.
Suggested change
| geopm_agent_power_governor(7) -- agent enforces a power cap | |
| =========================================================== | |
| geopm_agent_node_power_governor(7) -- agent enforces a node power cap | |
| ===================================================================== |
| ----------- | ||
|
|
||
| The :doc:`geopm::NodePowerGovernorAgent(3) <GEOPM_CXX_MAN_NodePowerGovernorAgent.3>` enforces a per-compute-node power cap of the | ||
| total platform power systems that support the Platform Power Limit feature. The platform power is determined by the platform vendor |
There was a problem hiding this comment.
Suggested change
| total platform power systems that support the Platform Power Limit feature. The platform power is determined by the platform vendor | |
| total platform power on systems that support the Platform Power Limit feature. The platform power is determined by the platform vendor |
Comment on lines
+82
to
+83
| The agent gates the Controller's control loop to a cadence of *5ms* | ||
| (milliseconds). |
There was a problem hiding this comment.
This accurately describes the current revision of the agent. But maybe the agent should use the Waiter class, which has a configurable control loop gate.
cmcantalupo
force-pushed
the
dev
branch
2 times, most recently
from
2cd441d
to
0859ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of a Node Power Governor Agent based upon the existing Power Governor Agent. Does not include a NodePowerGovernor
Additional Tasks (may be future PRs):