Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added basic ompt_target callback #2858

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Added basic ompt_target callback #2858

wants to merge 4 commits into from

Conversation

lhlawson
Copy link
Contributor

@lhlawson lhlawson commented Feb 17, 2023 •
edited

Addition of OMPT Target callback to track GPU offloads

@lhlawson lhlawson force-pushed the public-lhlawson-ompt-target-callbacks branch from d637c2d to 1890774 Compare February 18, 2023 00:10
@lhlawson lhlawson marked this pull request as ready for review March 30, 2023 18:51
cmcantalupo
cmcantalupo reviewed May 3, 2023
View reviewed changes
src/ompt_callback.cpp Outdated Show resolved Hide resolved
cmcantalupo
cmcantalupo reviewed May 3, 2023
View reviewed changes
Copy link
Contributor

@cmcantalupo cmcantalupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor whitespace issue, but LGTM otherwise

cmcantalupo
cmcantalupo reviewed May 22, 2023
View reviewed changes
src/ompt_callback.cpp Outdated Show resolved Hide resolved
lhlawson
lhlawson commented May 22, 2023
View reviewed changes
src/ompt_callback.cpp Outdated Show resolved Hide resolved
@cmcantalupo
Copy link
Contributor

cmcantalupo commented May 22, 2023 •
edited

Should add an integration test to show that this works (regions are added to report, and the runtime makes sense). If offload is asynchronous then we will be double counting runtime in the report which could be confusing for the reader or analysis code.

@lhlawson lhlawson force-pushed the public-lhlawson-ompt-target-callbacks branch from c188e17 to 48b970f Compare July 31, 2023 16:47
@lhlawson
Added basic ompt_target callback
6f1b0f1 
Signed-off-by: lhlawson <lowren.h.lawson@intel.com>
@lhlawson
WSP fixup
644ff8c 
Signed-off-by: lhlawson <lowren.h.lawson@intel.com>
@lhlawson lhlawson force-pushed the public-lhlawson-ompt-target-callbacks branch 4 times, most recently from 7f404df to 0a3d872 Compare August 9, 2023 15:50
@lhlawson
Added ompt target integration test
d5d3391 
Signed-off-by: lhlawson <lowren.h.lawson@intel.com>
@lhlawson lhlawson force-pushed the public-lhlawson-ompt-target-callbacks branch from 0a3d872 to d5d3391 Compare August 9, 2023 21:53
@lhlawson
Implemented region count checking, gpu usage check, and reduced regio…
e523ee8 
…n count

Signed-off-by: lhlawson <lowren.h.lawson@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmcantalupo cmcantalupo cmcantalupo left review comments

@avilcheslopez avilcheslopez Awaiting requested review from avilcheslopez

@sidjana sidjana Awaiting requested review from sidjana

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement an ompt_callback_target
2 participants
@lhlawson @cmcantalupo