Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable alternative to DBus communications: gRPC #2779

Draft
wants to merge 29 commits into
base: dev
Choose a base branch
from
Draft

Enable alternative to DBus communications: gRPC #2779

wants to merge 29 commits into from

Conversation

cmcantalupo
Copy link
Contributor

@cmcantalupo cmcantalupo commented Jan 4, 2023 •
edited 

- Enable gRPC for interprocess comms
- First pass at creating a prototype buffer definition
  for DBus methods used by ServiceIOGroup
- First draft of GEOPM grpc service
- Generate protobuffer files with autogen.sh
- Add some configure scripts for grpc.
- Add grpc requirements to spec file
- Add protoc-gen.sh to tarball
- Fixes #2775
- TODO: Write unit tests and fix broken unit tests
- TODO: Run integration tests for controls

@cmcantalupo cmcantalupo force-pushed the issue-2775 branch 2 times, most recently from 374d4d0 to 3a2a96c Compare January 4, 2023 21:23
@cmcantalupo cmcantalupo changed the title Enable alternative to DBus communications Enable alternative to DBus communications: gRPC Jan 4, 2023
@cmcantalupo cmcantalupo force-pushed the issue-2775 branch 13 times, most recently from 29250f6 to c2f6c6c Compare January 11, 2023 16:02
cmcantalupo
cmcantalupo commented Jan 11, 2023
View reviewed changes
service/geopm-service.spec.in Outdated
@@ -115,6 +113,8 @@ Requires: python3-dasbus >= 1.6
Requires: python3-jsonschema
Requires: python3-psutil
Requires: python3-cffi
Requires: python3-grpcio
Requires: python3-grpc-google-iam-v1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Requires: python3-grpc-google-iam-v1

@cmcantalupo cmcantalupo force-pushed the issue-2775 branch 5 times, most recently from 3fd1c78 to 0c789d7 Compare January 21, 2023 03:06
@cmcantalupo cmcantalupo force-pushed the issue-2775 branch 4 times, most recently from 97302ae to 520fa73 Compare February 3, 2023 15:39
@cmcantalupo cmcantalupo force-pushed the issue-2775 branch 3 times, most recently from f6f7180 to ed7f523 Compare August 3, 2023 22:29
cmcantalupo and others added 28 commits February 20, 2024 15:31
@cmcantalupo
Disable array bounds checking due to issue with protoc generated code
4f774e1 
- protocolbuffers/protobuf#7140

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@cmcantalupo
Update docker files
de0fa8a 
Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@cmcantalupo
Bring back deleted implementations
8b5fefb 
Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@cmcantalupo
Add proxy server to geopm-service installation
d72572b 
Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@cmcantalupo
Switch geopm systemd service to using grpc in unit file
6834108 
Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@cmcantalupo
fixup restore control
fedc08b 
Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@cmcantalupo
fixup /run/geopm and /etc/geopm path
ad53824 
Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@cmcantalupo
Fix call to get_user_access
9d87646 
Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@cmcantalupo
Use pio directly to get names of signals and controls
d7414c0 
Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@dannosliwcd @cmcantalupo
Periodically close inactive sessions in the grpc server
c753896
@cmcantalupo
[WIP] Change batch server from fork to subprocess
948edd9 
- This is a draft change
- Testing could be improved

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@lhlawson @cmcantalupo
Added basic CosmicTagger support for monitor & GPU CA experiments
8839ef2 
Signed-off-by: lowren.h.lawson@intel.com <lowren.h.lawson@intel.com>
@dannosliwcd @cmcantalupo
Add cosmictagger dockerfile
c133dda
@dannosliwcd @cmcantalupo
add a k8s config to run cosmictagger
b70c09a
@dannosliwcd @cmcantalupo
Add a geopm client to the cosmic tagger pod
0e5f3d6
@dannosliwcd @cmcantalupo
Add debian packaging outputs to gitignore
4c82167
@dannosliwcd @cmcantalupo
Build packages from source in the service Dockerfile
bb4a732
@obiTrinobiIntel @cmcantalupo
feat: k8s infra to support geopm-batch
2c828b2 
Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
Signed-off-by: Atanas Atanasov <atanas.atanasov@intel.com>
@cmcantalupo
Fixup cherry-pick issue
1be374b 
Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@cmcantalupo
Trim down New Features section of cloud branch readme
5ea18cb 
- The removed features are now part of the 3.0.0 release,
  no not "new".

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@cmcantalupo @bgeltz
A number of fixes discovered during code review
e2ec4b6 
- Stale reference to libgeopmpolicy
- Use of apt in non-interactive setting
- Documentation typos

Co-authored-by: Brad Geltz <brgeltz@gmail.com>
@dannosliwcd @cmcantalupo
Add missing tutorial files for the power sweep
901e3df
@cmcantalupo
Add patch for kubeflow/common git repository
da388ca 
- Applies to sha 4bcd3af369ff9d3ceaf72861c82d532ad2bc5655 from
  https://github.com/kubeflow/common

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@bgeltz @cmcantalupo
README fixes
d79e927 
Signed-off-by: Brad Geltz <brad.geltz@intel.com>
Change-Id: Iaedc7e5fac3bf2258789fbdebceb438c29477adb
@bgeltz @cmcantalupo
Use libgeopmload in the k8-monitor
f0bf2a2 
- Necessary until containers are updated with 3.0.

Signed-off-by: Brad Geltz <brad.geltz@intel.com>
Change-Id: Ifaf6c3d89827362c50a243f52b8e9ca767f3e534
@cmcantalupo
Remove BatchServerTest entirely
6c5216b 
Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@cmcantalupo
Bring back work-around to avoid calling into pio early
4324b48 
- This is to avoid issues with LevelZero

Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@cmcantalupo
Remove unit tests that are broken
68737b8 
Signed-off-by: Christopher M. Cantalupo <christopher.m.cantalupo@intel.com>
@bgeltz bgeltz mentioned this pull request May 22, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgeltz bgeltz bgeltz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cmcantalupo @bgeltz @dannosliwcd @lhlawson @obiTrinobiIntel