Fix nose2 warnings #410
Merged
Fix nose2 warnings #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninamiolane
approved these changes
Jan 28, 2020
ninamiolane
reviewed
Jan 28, 2020
| @@ -460,7 +461,7 @@ def while_loop_body(iteration, mean, variance, sq_dist): | |||
| maximum_iterations=n_max_iterations) | |||
|
|
|||
| if last_iteration == n_max_iterations: | |||
| print('Maximum number of iterations {} reached.' | |||
| warnings.warn('Maximum number of iterations {} reached.' | |||
There was a problem hiding this comment.
The continuous integration tests fail because of this line (flake8 complains). Could you pep8 the style? Thanks!
There was a problem hiding this comment.
There was a problem hiding this comment.
forgot to run flake8 one last time before submitting PR. Just fixed it
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
=========================================
Coverage ? 93.45%
=========================================
Files ? 90
Lines ? 10486
Branches ? 0
=========================================
Hits ? 9800
Misses ? 686
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #380
ignores UserWarnings on Numpy and PyTorch backends when running the command
nose2 tests. Only Sklearn deprecated FutureWarning is left in (can be ignored upon request).Unfortunately I'm unable to see the results using the Tensorflow backend due to the following issue and my computer being a bit older:
github.com/tensorflow/tensorflow/issues/17411