Undo / Redo History Function #741
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeofsumit
suggested changes
Jan 1, 2021
There was a problem hiding this comment.
- Undo Redo Logic sollte komplett gekapselt sein
- Scopes: Mode, Drawing Mode, Global
- GlobalReverting should be ModeReverting
- New GlobalRevert across everything
- pm:edit/drag/etc ->
createChangeOnLayer - addHistoryEntry, removeHistoryEntry, getHistory
- Transactions vs Snapshots: Consistency in Applying and Storing
- Architektur: global History with EVERYTHING (one array), then filter based on
Kontext
[
{
diff: `theChange`,
layer: `<layerRef>`
mode: `Removal/Edit/etc`
action: `Draw/Move/Drag/...`
}
]
|
where does this feature stands? |
|
@t1a2l it is currently on hold because we don't have the time to develop it |
|
Any chance of this getting merged and published soon? |
|
@winston01 no |
|
Are there any updated on this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is under development!
Having lots of tests from different people would be nice
Fix: #320