FIX: improve and fix PolynomialSolution #572

bobmyhill · 2024-03-01T17:24:09Z

This PR improves the PolynomialSolution by:

Changing the user input to give indices and exponents, rather than repeated indices for higher powers
Internally changing the first and second derivative calculations to be much more efficient and work quickly for high exponents.
Adding several tests, which would have caught a previously uncaught bug in the second derivative calculations

This PR is a breaking change, as it changes the behaviour of PolynomialSolution.

bobmyhill added 3 commits March 1, 2024 16:40

improve PolynomialSolution

713b274

added docstrings

64890b2

added isochemical consistency check

8df0acb

bobmyhill force-pushed the improve_PolynomialSolution branch from 9ecde6f to 8df0acb Compare March 1, 2024 17:25

bobmyhill merged commit 4dc652d into geodynamics:master Mar 1, 2024
6 checks passed

bobmyhill deleted the improve_PolynomialSolution branch March 1, 2024 17:38

bobmyhill added this to In progress in BurnMan 2 Mar 24, 2024

bobmyhill moved this from In progress to Done in BurnMan 2 Mar 24, 2024

Provide feedback