-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1092 review edition 2 rl ii #1094
Conversation
Main aim here is to be more clear and concise. Heads-up and friendly nudge @mtennekes re. v4 release, could it coincide with geocompr2 release date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking good except for clobbering globe.png
images/globe.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
I can have a look at this tomorrow! |
@@ -264,13 +283,10 @@ knitr::kable(top_dls[1:5, 1:2], digits = 0, | |||
# cranlogs::cran_top_downloads(when = "last-month") # most downloaded pkgs | |||
``` | |||
|
|||
A parallel group of developments relates to the [rspatial](https://github.com/rspatial) set of packages.^[Note the difference between "r-spatial", organization containing packages such as **sf**, and "rspatial", organization responsible for **terra**.] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Robinlovelace maybe it would be good to keep the footnote about the rspatial/r-spatial difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree it's potentially useful info. Can be found out online and not sure it lives in the book. No big objections to re-adding it or strong feelings, just felt a bit like too much info to me and footnotes are fiddly and generally discouraged I think.
Thoughts @jannes-m to get another opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with both of you -:). It is useful info but oth we should omit footnotes where possible. In this case, I think we can delete the footnote because the information given in the footnote is already given in the main text. However, one might add something like "note the difference r-spatial vs. rspatial" in parentheses in the main text.
|
||
Nowadays, researchers and practitioners have no such limitations and in some cases face the opposite problem: too much data; too many tools. | ||
Most phones now have a global positioning (GPS\index{GPS}) receiver. | ||
Sensors ranging from satellites and semi-autonomous vehicles to citizen scientists incessantly measure every part of the world. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are citizen scientists "sensors"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so in this context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments and additional changes so far.
OK guys good to merge? Plan to do so later today. |
Give me a moment, I am now going across your changes and the intro text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Robin, thanks for rewriting the intro. Looks good to me. There were only two sentences which need to be clarified a bit and then we are good to merge -:)
I will update the gis bridges section in the intro later today. But for now I need to jump into a few meetings. |
Co-authored-by: Jannes Muenchow <malnamalja@gmx.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there...
01-introduction.Rmd
Outdated
@@ -297,7 +297,7 @@ The 1990s saw the development of numerous S scripts and a handful of packages fo | |||
By the year 2000 there were R packages for various spatial methods, including "point pattern analysis, geostatistics, exploratory spatial data analysis and spatial econometrics" [@bivand_open_2000]. | |||
Some of these, notably **spatial**, **sgeostat** and **splancs** are still available on CRAN\index{CRAN} [@rowlingson_splancs_1993; @rowlingson_splancs_2017;@venables_modern_2002; @majure_sgeostat_2016]. | |||
Key spatial packages were described in @ripley_spatial_2001, which outlined R packages for spatial smoothing and interpolation [@akima_akima_2016; @jr_geor_2016] and point pattern analysis [@rowlingson_splancs_2017; @baddeley_spatial_2015]. | |||
One of these (**spatstat**) is still being actively, more than 20 years after it was first released. | |||
One of these (**spatstat**) is still being actively maintained, more than 20 years after it was first released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there...
@@ -342,7 +342,7 @@ An important capability of **raster** and **terra** is their ability to work wit | |||
|
|||
In parallel with these developments of class systems and methods came the support for R as an interface to dedicated GIS software. | |||
**GRASS** [@bivand_using_2000] and follow-on packages **spgrass6**, **rgrass7** and **rgrass** (for GRASS GIS\index{GRASS GIS} GIS 6, 7, 7 + 8 respectively) were prominent examples in this direction [@bivand_rgrass7_2016;@bivand_spgrass6_2016;@R-rgrass]. | |||
Other examples of bridges between R and GIS include **RSAGA** [@R-RSAGA, first published in 2008]\index{RSAGA (package)}, **RPyGeo** [@brenning_arcgis_2012, first published in 2008], **RQGIS** [@muenchow_rqgis:_2017, first published in 2016]\index{RQGIS (package)}, and more (see Chapter \@ref(gis)). | |||
Other examples of bridges between R and GIS include bridges to QGIS via **qgisprocess** [@R-qgisprocess], SAGA via **Rsagacmd** [@R-Rsagacmd] or **RSAGA** [@R-RSAGA]\index{RSAGA (package)} and ArcGIS via **RPyGeo** [@brenning_arcgis_2012, first published in 2008], and more (see Chapter \@ref(gis)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Let's just merge this. |
…tion-2-rl-ii 1092 review edition 2 rl ii fb366cf
No description provided.