Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1092 review edition 2 rl ii #1094

Merged
merged 38 commits into from
May 8, 2024
Merged

1092 review edition 2 rl ii #1094

merged 38 commits into from
May 8, 2024

Conversation

Robinlovelace
Copy link
Collaborator

No description provided.

@Robinlovelace Robinlovelace linked an issue May 4, 2024 that may be closed by this pull request
@Robinlovelace Robinlovelace marked this pull request as ready for review May 4, 2024 15:04
Copy link
Collaborator Author

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good except for clobbering globe.png

images/globe.png Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@jannes-m
Copy link
Collaborator

jannes-m commented May 5, 2024

I can have a look at this tomorrow!

@@ -264,13 +283,10 @@ knitr::kable(top_dls[1:5, 1:2], digits = 0,
# cranlogs::cran_top_downloads(when = "last-month") # most downloaded pkgs
```

A parallel group of developments relates to the [rspatial](https://github.com/rspatial) set of packages.^[Note the difference between "r-spatial", organization containing packages such as **sf**, and "rspatial", organization responsible for **terra**.]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Robinlovelace maybe it would be good to keep the footnote about the rspatial/r-spatial difference

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree it's potentially useful info. Can be found out online and not sure it lives in the book. No big objections to re-adding it or strong feelings, just felt a bit like too much info to me and footnotes are fiddly and generally discouraged I think.

Thoughts @jannes-m to get another opinion?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both of you -:). It is useful info but oth we should omit footnotes where possible. In this case, I think we can delete the footnote because the information given in the footnote is already given in the main text. However, one might add something like "note the difference r-spatial vs. rspatial" in parentheses in the main text.

01-introduction.Rmd Outdated Show resolved Hide resolved
01-introduction.Rmd Outdated Show resolved Hide resolved
01-introduction.Rmd Outdated Show resolved Hide resolved
01-introduction.Rmd Show resolved Hide resolved

Nowadays, researchers and practitioners have no such limitations and in some cases face the opposite problem: too much data; too many tools.
Most phones now have a global positioning (GPS\index{GPS}) receiver.
Sensors ranging from satellites and semi-autonomous vehicles to citizen scientists incessantly measure every part of the world.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are citizen scientists "sensors"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so in this context.

01-introduction.Rmd Show resolved Hide resolved
Copy link
Collaborator Author

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments and additional changes so far.

index.Rmd Outdated Show resolved Hide resolved
01-introduction.Rmd Outdated Show resolved Hide resolved
01-introduction.Rmd Outdated Show resolved Hide resolved
@Robinlovelace
Copy link
Collaborator Author

OK guys good to merge? Plan to do so later today.

@jannes-m
Copy link
Collaborator

jannes-m commented May 7, 2024

Give me a moment, I am now going across your changes and the intro text.

Copy link
Collaborator

@jannes-m jannes-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Robin, thanks for rewriting the intro. Looks good to me. There were only two sentences which need to be clarified a bit and then we are good to merge -:)

01-introduction.Rmd Outdated Show resolved Hide resolved
01-introduction.Rmd Outdated Show resolved Hide resolved
01-introduction.Rmd Outdated Show resolved Hide resolved
@jannes-m
Copy link
Collaborator

jannes-m commented May 7, 2024

I will update the gis bridges section in the intro later today. But for now I need to jump into a few meetings.

Co-authored-by: Jannes Muenchow <malnamalja@gmx.de>
Copy link
Collaborator Author

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there...

@@ -297,7 +297,7 @@ The 1990s saw the development of numerous S scripts and a handful of packages fo
By the year 2000 there were R packages for various spatial methods, including "point pattern analysis, geostatistics, exploratory spatial data analysis and spatial econometrics" [@bivand_open_2000].
Some of these, notably **spatial**, **sgeostat** and **splancs** are still available on CRAN\index{CRAN} [@rowlingson_splancs_1993; @rowlingson_splancs_2017;@venables_modern_2002; @majure_sgeostat_2016].
Key spatial packages were described in @ripley_spatial_2001, which outlined R packages for spatial smoothing and interpolation [@akima_akima_2016; @jr_geor_2016] and point pattern analysis [@rowlingson_splancs_2017; @baddeley_spatial_2015].
One of these (**spatstat**) is still being actively, more than 20 years after it was first released.
One of these (**spatstat**) is still being actively maintained, more than 20 years after it was first released.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

01-introduction.Rmd Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there...

@@ -342,7 +342,7 @@ An important capability of **raster** and **terra** is their ability to work wit

In parallel with these developments of class systems and methods came the support for R as an interface to dedicated GIS software.
**GRASS** [@bivand_using_2000] and follow-on packages **spgrass6**, **rgrass7** and **rgrass** (for GRASS GIS\index{GRASS GIS} GIS 6, 7, 7 + 8 respectively) were prominent examples in this direction [@bivand_rgrass7_2016;@bivand_spgrass6_2016;@R-rgrass].
Other examples of bridges between R and GIS include **RSAGA** [@R-RSAGA, first published in 2008]\index{RSAGA (package)}, **RPyGeo** [@brenning_arcgis_2012, first published in 2008], **RQGIS** [@muenchow_rqgis:_2017, first published in 2016]\index{RQGIS (package)}, and more (see Chapter \@ref(gis)).
Other examples of bridges between R and GIS include bridges to QGIS via **qgisprocess** [@R-qgisprocess], SAGA via **Rsagacmd** [@R-Rsagacmd] or **RSAGA** [@R-RSAGA]\index{RSAGA (package)} and ArcGIS via **RPyGeo** [@brenning_arcgis_2012, first published in 2008], and more (see Chapter \@ref(gis)).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

01-introduction.Rmd Outdated Show resolved Hide resolved
@Robinlovelace
Copy link
Collaborator Author

Let's just merge this.

@Robinlovelace Robinlovelace merged commit fb366cf into main May 8, 2024
3 checks passed
@Robinlovelace Robinlovelace deleted the 1092-review-edition-2-rl-ii branch May 8, 2024 08:40
github-actions bot pushed a commit that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Edition 2 RL II
4 participants