don't serialize empty array metadata #498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm looks like I have some issues with the union handling :/ |
paleolimbot
reviewed
Feb 6, 2024
| let dt = GeoDataType::Point(CoordType::Interleaved); | ||
| let field = dt.to_field("field_name", true, None); | ||
| assert_eq!(field.metadata().len(), 1); | ||
| assert!(field.metadata().contains_key("ARROW:extension:name")); |
There was a problem hiding this comment.
I think I misunderstood one of your comments about the {}...I am pretty sure that geoarrow-c will serialize empty metadata as {}, even though the spec says to omit the key. I do think having a canonical way to represent "no metadata" is helpful (so that non-geo-aware libraries see the schemas as equal); however, it definitely doesn't cause a problem as I might have suggested 😬
There was a problem hiding this comment.
Ah ok. Just the changes in #497 would change {"crs": null} to {}. The attempted changes in this PR would omit the key entirely from the metadata. I think we can consume either input
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #497 ; progress for #430