Support saving more than one image at a time #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The previous method would loop over the image references and try to save each one. Even if this did work, the tar archive would overwrite the previous instance on each invocation meaning that the last image specified on the CLI would be the only one in the archive. Even then, this method would hang because a filesystem lock was acquired on the underlying BoltDB during the first invocation of the loop (within `client.createWorkerOpt(...)`) but never freed. Because of this, every subsequent call would only hang as seen in genuinetools#332 - This refactor properly passes all image references to the underlying buildkit type to let it construct the image archive with all references specified.
|
I know that you're busy with other things @jessfraz and @AkihiroSuda but is there anyway that you could take a quick look at this fix? It resolves a core functionality issue and I really want to avoid running a forked copy of the project long term. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous method would loop over the image references and try to
save each one. Even if this did work, the tar archive would overwrite
the previous instance on each invocation meaning that the last image
specified on the CLI would be the only one in the archive. Even then,
this method would hang because a filesystem lock was acquired on the
underlying BoltDB during the first invocation of the loop
(within
client.createWorkerOpt(...)) but never freed. Because of this, everysubsequent call would only hang as seen in Hang when saving multiple images to tarball #332
This refactor properly passes all image references to the underlying
buildkit type to let it construct the image archive with all references
specified.