Login to Azure container Registry Fails #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ageekymonk
changed the title
AkihiroSuda
reviewed
Aug 31, 2020
| @@ -104,7 +104,7 @@ func (cmd *loginCommand) Run(args []string) error { | |||
| } | |||
|
|
|||
| // Attempt to login to the registry. | |||
| r, err := registryapi.New(cliconfigtypes2dockerapitypes(authConfig), registryapi.Opt{Debug: debug}) | |||
| r, err := registryapi.New(cliconfigtypes2dockerapitypes(authConfig), registryapi.Opt{Debug: debug, SkipPing: true}) | |||
| if err != nil { | |||
| return fmt.Errorf("creating registry client failed: %v", err) | |||
There was a problem hiding this comment.
Can we fallback to ping on error
There was a problem hiding this comment.
Sure. will make the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Img cannot be used to login to azure container registry. This is due to Pinging registry without auth credentials causing it to fail. So removed pinging altogether.
PS: Ideally, the fix should be in reg the library but there is no release for nearly a year. Until we get that change in reg, adding a workaround here to fix this.