-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sci-physics/madgraph5: new package, add 3.5.3 #1270
Conversation
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
|
||
src_unpack() { | ||
# Perserve permissions | ||
tar xvzf "${DISTDIR}/${MY_PNN}-${PV}.tar.gz" -C "${WORKDIR}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|| die
# symlink entrypoint | ||
dosym ../../opt/${MY_PF}/bin/mg5_aMC /usr/bin/mg5_aMC3 | ||
dosym ../opt/${MY_PF} /opt/"${MY_PNN}" | ||
mv "${WORKDIR}/${MY_PF}" "${ED}/opt/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|| die
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parts of the ebuild were quite old (on my gentoo time scale :)). I think pkgdev commit
should catch these, because missing them is easy and stupid...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parts of the ebuild were quite old (on my gentoo time scale :)). I think
pkgdev commit
should catch these, because missing them is easy and stupid...
That would be super useful, I expect the difficulty here is teaching pkgcheck to differentiate between an external command and an internal command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess set -e(uo pipefail)
in an ebuild would break some eclasses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that would probably break nonfatal
as well as alternative failure status handling that we have in some places.
Co-authored-by: Andrew Nowa Ammerlaan <andrewammerlaan@gentoo.org>
Co-authored-by: Andrew Nowa Ammerlaan <andrewammerlaan@gentoo.org>
hepmc? ( | ||
sci-physics/hepmc:2 | ||
sci-physics/hepmc:3 | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's own install just install hepmc2, but I hope they update it soon. I'll drop the :3 for now, but some dependencies might pull it in either way.
PR created by pkgpr.
This is a working package, despite not having full dependencies+use flags.
I also have them (sort of) ready, but testing all of it is a bit much :)
There will also be a pot. cyclic dependency. Given that herwig-7.X.Y uses openloops and madgraph itself. A lot of codes, but having them all nicely orchestrated in ::sci is what I aim for.