Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x11-wm/fvwm: Fix implicit declaration of function png_get_color_type #36676

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

x11-wm/fvwm: Fix implicit declaration of function png_get_color_type #36676

wants to merge 1 commit into from
+191 −0

Conversation

listout
Copy link
Contributor

@listout listout commented May 14, 2024

Closes: https://bugs.gentoo.org/921601

Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @listout
Areas affected: ebuilds
Packages affected: x11-wm/fvwm

x11-wm/fvwm: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 921601

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 14, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-14 17:10 UTC
Newest commit scanned: cc27418
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/116fc34824/output.html

@eli-schwartz
Copy link
Contributor

eli-schwartz commented May 16, 2024 •
edited

Patch is entirely bogus. It unconditionally includes png.h, but Fpng.h already does that conditional to whether USE=png. It completely misdiagnoses what the code is trying to do. :(

See b.g.o for details.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-16 21:35 UTC
Newest commit scanned: 484d636
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5a95cc4312/output.html

@listout
Copy link
Contributor Author

listout commented May 29, 2024

@eli-schwartz I commented on b.g.o with a modified patch. Did you get a chance to have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
4 participants
@listout @gentoo-bot @gentoo-repo-qa-bot @eli-schwartz