-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distutils-r1.eclass: wheel reuse #36672
Conversation
d8a9a4e
to
8fabfdc
Compare
8fabfdc
to
9fe71ac
Compare
Pull request CI reportReport generated at: 2024-05-14 12:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-05-14 13:31 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
39449a3
to
ae97fe8
Compare
That said, when this is reviewed and all, I think I'll only push the eclass bits and leave |
Pull Request assignmentSubmitter: @mgorny dev-python/psutil: @gentoo/python Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok but not tested. I assume you have with all DISTUTILS_EXT on your system at least
ae97fe8
to
c8ce243
Compare
Pull request CI reportReport generated at: 2024-05-15 16:11 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2024-05-15 17:01 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Actually, I need to add some more logic to prevent this from breaking ebuilds that call |
Store the created wheel path in DISTUTILS_WHEEL_PATH when returning from distutils_pep517_install. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
If the package is creating at least one pure Python wheel, check whether the baseline package contents (i.e. everything but compiled Python modules, extensions and .dist-info) match between implementations. This is meant to ensure that we can safely optimize builds by reusing pure Python wheels from previous builds. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Support reusing the wheels built for earlier Python implementations if they are compatible with the subsequent implementations being built. This includes pure Python wheels in packages that do not set DISTUTILS_EXT, and stable ABI wheels. Closes: https://bugs.gentoo.org/931689 Signed-off-by: Michał Górny <mgorny@gentoo.org>
Closes: https://bugs.gentoo.org/905863 Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
c8ce243
to
f241da5
Compare
Switched to an associative array, and matched wheels to source directories. That should prevent a wrong wheel from being used. |
Pull request CI reportReport generated at: 2024-05-17 08:01 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Fix epytest to call `die -n` after performing the cleanup, rather than before. This ensures that stray cache files are cleaned up even if we're actually going to die, e.g. when using `FEATURES=test-fail-continue`. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Pull request CI reportReport generated at: 2024-05-17 13:46 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
distutils-r1 updates related to https://bugs.gentoo.org/931689.
Includes some example ebuilds with explicit
IUSE=stable-api
(still not sure if we should do that).Includes
EPYTEST_FLAGS
, as requested by @asarubbo.Includes updates for scikit-build-core 0.9.4. Since it's
~arch
, I went straight for requiring the new version.