app-editors/helix: Remove grammar USE flag
#36660
Conversation
Pull Request assignmentSubmitter: @vadorovsky app-editors/helix: @chutz, @freijon, @gentoo/proxy-maint Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
vadorovsky
force-pushed
the
remove-helix-grammar
branch
from
6f5ecf9
to
a3281d0
Compare
Pull request CI reportReport generated at: 2024-05-13 10:30 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Hmm, it doesn't look good:
* QA Notice: Symbolic link /usr/share/helix/runtime/grammars/sources/qmljs/queries/highlights-javascript.scm points to /usr/share/helix/runtime/grammars/sources/qmljs/node_modules/tree-sitter-javascript/queries/highlights.scm which does not exist.
>>> /usr/share/helix/runtime/grammars/sources/qmljs/queries/highlights-javascript.scm -> ../node_modules/tree-sitter-javascript/queries/highlights.scm
* QA Notice: Symbolic link /usr/share/helix/runtime/grammars/sources/qmljs/queries/highlights-typescript.scm points to /usr/share/helix/runtime/grammars/sources/qmljs/node_modules/tree-sitter-typescript/queries/highlights.scm which does not exist.
>>> /usr/share/helix/runtime/grammars/sources/qmljs/queries/highlights-typescript.scm -> ../node_modules/tree-sitter-typescript/queries/highlights.scm
* QA Notice: Symbolic link /usr/share/helix/runtime/grammars/sources/janet-simple/bin/tree-sitter points to /usr/share/helix/runtime/grammars/sources/janet-simple/tree-sitter/target/release/tree-sitter which does not exist.
>>> /usr/share/helix/runtime/grammars/sources/janet-simple/bin/tree-sitter -> ../tree-sitter/target/release/tree-sitter
* QA Notice: Symbolic link /usr/share/helix/runtime/grammars/sources/twig/node_modules/.bin/tree-sitter points to /usr/share/helix/runtime/grammars/sources/twig/node_modules/tree-sitter-cli/cli.js which does not exist.
>>> /usr/share/helix/runtime/grammars/sources/twig/node_modules/.bin/tree-sitter -> ../tree-sitter-cli/cli.js
I wonder if the grammars directory should just be deleted and not intalled, if it's attained by the user instead?
Probably. Let me try that. |
vadorovsky
force-pushed
the
remove-helix-grammar
branch
from
a3281d0
to
2f475ba
Compare
|
@juippis Sorry for late follow up. The error should be gone now, I fixed it by explicitly specifying stuff from |
Pull request CI reportReport generated at: 2024-05-23 07:50 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Fetching grammars is done with git, therefore doing that during the package build is not the best, because git rigtfully complains about "unsafe directories". Instead of micromanaging grammar builds, notify the user how to do it after installation. The procedure is to run: ``` hx --grammar fetch hx --grammar build ``` Signed-off-by: Michal Rostecki <vadorovsky@protonmail.com>
vadorovsky
force-pushed
the
remove-helix-grammar
branch
from
2f475ba
to
6ecae1c
Compare
Pull request CI reportReport generated at: 2024-05-23 09:15 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Fetching grammars is done with git, therefore doing that during the package build is not the best, because git rigtfully complains about "unsafe directories".
Instead of micromanaging grammar builds, notify the user how to do it after installation. The procedure is to run:
Please check all the boxes that apply:
Signed-off-byline to every commit in the pull request.pkgcheck scan --commits --netto check for issues with my commits.Please note that all boxes must be checked for the pull request to be merged.