Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update entities to have an ID field #266

Closed
wants to merge 2 commits into from

Conversation

SteeledSlagle13
Copy link
Contributor

Add id fields to all entities
Field maps to the directory name. This makes it easier to reference image folders if consumers are just using the GET :type/all endpoint.
(some entities already had an id field mapping to their directory... this just adds it to all other entities)

  • removed \u0009 character from food/de.json -- lint
  • removed a en,json file
  • added correct data for blackcliff-agate/en.json

Copy link
Collaborator

@man90es man90es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be much wiser to implement adding those IDs programmatically, rather than worry about adding a correct ID to every existing and future data file

@man90es
Copy link
Collaborator

man90es commented May 16, 2024

I kinda need this feature too, so I'm going to start working on my own version next week if there's no activity from @SteeledSlagle13 until then

@M4GICB
Copy link
Collaborator

M4GICB commented May 20, 2024

@man90es and @SteeledSlagle13 - is this fixed now with pr #279 ?

@man90es
Copy link
Collaborator

man90es commented May 20, 2024

@man90es and @SteeledSlagle13 - is this fixed now with pr #279 ?

Yeah we can close this one unless that blackcliff-agate/en.json change is any valuable. My browser freezes when I try to check what that change is

@M4GICB
Copy link
Collaborator

M4GICB commented May 20, 2024

I was able to check. The blackcliff-agate/en.json change is just adding the id field and all the other changes in the file seem like linter changes.

@M4GICB M4GICB closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants