New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fix to RangeEncoder #100

Open

WinLinux1028 wants to merge 1 commit into gendx:master from WinLinux1028:master

WinLinux1028 commented May 20, 2023

The rationale for this modification can be found below.
https://github.com/tukaani-project/xz-java/blob/master/src/org/tukaani/xz/rangecoder/RangeEncoder.java#L29
https://github.com/tukaani-project/xz-java/blob/master/src/org/tukaani/xz/rangecoder/RangeEncoder.java#L115


          Small fix to RangeEncoder

d33118a

The rationale for this modification can be found below.
https://github.com/tukaani-project/xz-java/blob/master/src/org/tukaani/xz/rangecoder/RangeEncoder.java#L29
https://github.com/tukaani-project/xz-java/blob/master/src/org/tukaani/xz/rangecoder/RangeEncoder.java#L115

Owner

gendx commented Nov 5, 2023

Thank you for the contribution.

As far as I understand it, the main difference is about making the cache size a u64. The normalize() function doesn't need to be remove for this change.
It would be good to have a test case that triggers the behavior, to avoid future regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment