Fixes Issue #51 #53
Open
Fixes Issue #51 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfJanetDavis
requested changes
Sep 24, 2020
ProfJanetDavis
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
I finally tested this PR, and here's what I'm seeing.
It seems like the first sentence should be flagged, and indeed the backend is flagging it:
Effort vs Accomplishment ! [30-48]: Effort vs Accomplishment: The word 'willing' tends to speak about effort more than accomplishment. (Try replacing with phrasing that emphasizes accomplishment.) ! [0-15]: Effort vs Accomplishment: The word 'willing' tends to speak about effort more than accomplishment. (Try replacing with phrasing that emphasizes accomplishment.)
So while you've resolved the issues with the "undefined" at the end of the text, the first flag is still not being displayed. I wonder if the problem is that your fix assumes the flags are in order, but they are not necessarily. Let's discuss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.