Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Geminabox dependency fetching with Adapter pattern #579

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

numbata
Copy link

@numbata numbata commented Apr 14, 2024

Motivation

Due to the shutdown of the https://bundler.rubygems.org/api/v1/dependencies endpoint, we needed to update our dependency fetching approach to ensure continuous operation. It is also important that Geminabox continues to work well behind other gem proxies that don't have the same "index" feature as RubyGems.org.

Solution

This PR updates the dependency fetching process in Geminabox by introducing an adapter pattern. This new structure adds flexibility to our dependency fetching mechanism by allowing different RubyGems APIs to be used through separate adapter modules.

This update helps Geminabox handle changes in gem source services while still supporting existing systems that use different setups.

Related links:

@numbata numbata changed the title Update Geminabox Dependency Fetching with Adapter Pattern Update Geminabox dependency fetching with Adapter pattern Apr 14, 2024
@numbata
Copy link
Author

numbata commented Apr 20, 2024

@tnir May I ask you to take a look at the PR?

@numbata
Copy link
Author

numbata commented Apr 26, 2024

@rikas @tnir Feel free to let me know if I should stop pinging you and/or should communicate in a different more efficient way (slack/discord/telegram/etc) about the "Gem-In-A-Box".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant