Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rubygems 3.5+ #572

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cboos
Copy link

@cboos cboos commented Dec 28, 2023

'rubygems/indexer' is now shipped separately.

See rubygems/rubygems#7085.


When rubygems 3.5 is installed (3.5.3 shipping with Ruby 3.3), the proposed change is enough to make gem inabox work again and avoid the following error:

> gem inabox
<internal:C:/Dev/Ruby33-x64/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require': cannot load such file -- rubygems/indexer (LoadError)
        from <internal:C:/Dev/Ruby33-x64/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
        from C:/Dev/Ruby33-x64/lib/ruby/gems/3.3.0/gems/geminabox-2.1.0/lib/geminabox.rb:8:in `<top (required)>'

Besides, installing rubygems-generate_index when a version of rubygems older than 3.5 is installed seems to be harmless, but I only did limited testing (Ruby 3.0.3, rubygems 3.4.7 and gem inabox used as a client, so it likely won't use the indexer itself).

'rubygems/indexer' is now shipped separately.

See rubygems/rubygems#7085

Signed-off-by: Christian Boos <christian.boos@free.fr>
@dskecse
Copy link

dskecse commented Jan 16, 2024

Bumped into the same issue with Ruby 3.3.0 and RubyGems 3.5.4:

<internal:/Users/dskecse/.rubies/ruby-3.3.0/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require': cannot load such file -- rubygems/indexer (LoadError)
        from <internal:/Users/dskecse/.rubies/ruby-3.3.0/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
        from /Users/dskecse/.gem/ruby/3.3.0/gems/geminabox-2.1.0/lib/geminabox.rb:8:in `<top (required)>'
        from <internal:/Users/dskecse/.rubies/ruby-3.3.0/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
        from <internal:/Users/dskecse/.rubies/ruby-3.3.0/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
        from /Users/dskecse/.gem/ruby/3.3.0/gems/geminabox-2.1.0/lib/geminabox_client.rb:5:in `<top (required)>'
        from <internal:/Users/dskecse/.rubies/ruby-3.3.0/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
        from <internal:/Users/dskecse/.rubies/ruby-3.3.0/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:127:in `require'
        from /Users/dskecse/.gem/ruby/3.3.0/gems/geminabox-2.1.0/lib/rubygems/commands/inabox_command.rb:40:in `last_minute_requires!'
        from /Users/dskecse/.gem/ruby/3.3.0/gems/geminabox-2.1.0/lib/rubygems/commands/inabox_command.rb:44:in `execute'
        from /Users/dskecse/.rubies/ruby-3.3.0/lib/ruby/site_ruby/3.3.0/rubygems/command.rb:326:in `invoke_with_build_args'
        from /Users/dskecse/.rubies/ruby-3.3.0/lib/ruby/site_ruby/3.3.0/rubygems/command_manager.rb:254:in `invoke_command'
        from /Users/dskecse/.rubies/ruby-3.3.0/lib/ruby/site_ruby/3.3.0/rubygems/command_manager.rb:193:in `process_args'
        from /Users/dskecse/.rubies/ruby-3.3.0/lib/ruby/site_ruby/3.3.0/rubygems/command_manager.rb:151:in `run'
        from /Users/dskecse/.rubies/ruby-3.3.0/lib/ruby/site_ruby/3.3.0/rubygems/gem_runner.rb:56:in `run'
        from /Users/dskecse/.rubies/ruby-3.3.0/bin/gem:12:in `<main>'

/cc @tnir

@walf443 walf443 mentioned this pull request Jan 16, 2024
Copy link

You should update this pull request by commenting on it. Otherwise the PR will be closed in 14 days.

@cboos
Copy link
Author

cboos commented Mar 21, 2024

Ping? Any chance this could get merged?

Copy link

You should update this pull request by commenting on it. Otherwise the PR will be closed in 14 days.

@zarqman
Copy link

zarqman commented May 21, 2024

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants