Fix Geminabox::VERSION instantiation failure #514

nelsnelson · 2022-12-30T01:50:57Z

Getting the following error when using bundler to install and run geminabox.

NameError - uninitialized constant Geminabox::VERSION

Problem is that even though the version.rb module is being required and loaded successfully, some constant VERSION is already defined, and so the Geminabox module never gets to define its version because unless defined? VERSION evaluates to false.

github-actions · 2023-03-01T00:53:20Z

You should update this pull request by commenting on it. Otherwise the PR will be closed in 14 days.

pboling

LGTM

nelsnelson · 2023-03-10T01:56:55Z

@pboling - It is unclear to me how I might link this PR to its issue: #506

pboling · 2023-03-10T19:16:18Z

@pboling I used to think that writing something like "closes #506" in a commit message, or in the PR description, would auto close the issue, but it doesn't seem to be the case currently. :/

pboling · 2023-03-10T19:17:54Z

Since this PR is significantly updating the README instructions, I am wondering how I've messed this up, or if we need to also update the docker build command.

❯ vi config.ru
❯ vi Gemfile
❯ bundle install
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Using bundler 2.4.8
Using faraday-net_http 3.0.2
Using builder 3.2.4
Using httpclient 2.8.3
Using nesty 1.0.2
Using reentrant_flock 0.1.1
Fetching tilt 2.1.0
Using ruby2_keywords 0.0.5
Using rack 2.2.6.3
Using faraday 2.7.4
Using mustermann 2.0.2
Using rack-protection 2.2.4
Installing tilt 2.1.0
Using sinatra 2.2.4
Using geminabox 2.1.0
Bundle complete! 1 Gemfile dependency, 14 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
❯ docker build -t geminabox .

unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /Users/pboling/src/geminabox-srv/Dockerfile: no such file or directory
❯ ls
Gemfile      Gemfile.lock config.ru

~~The docker build command isn't working. Does it work for other people?~~

Nevermind - I figured it out. This sentence is really easy to miss:

Move this Dockerfile into a directory that you want to use for your server.

I had even read it, but I had no idea what Dockerfile it was referring to as it never told me to checkout the geminabox source code.

Also it is self-contradictory.

That directory only needs to contain:

config.ru (explained above)
Gemfile
Gemfile.lock

It should instead be:

config.ru (explained above)
Dockerfile (copied from the root of this repo)
Gemfile
Gemfile.lock

pboling · 2023-03-10T23:27:44Z

Another issue is that, once I have the docker image built it won't run, using the files as directed in the README. The error is Couldn't find handler for: puma, thin, falcon, webrick. (LoadError), stacktrace below:

2023-03-10 16:25:04 /usr/local/bundle/gems/rack-2.2.6.3/lib/rack/handler.rb:45:in `pick': Couldn't find handler for: puma, thin, falcon, webrick. (LoadError)
2023-03-10 16:25:04     from /usr/local/bundle/gems/rack-2.2.6.3/lib/rack/handler.rb:60:in `default'
2023-03-10 16:25:04     from /usr/local/bundle/gems/rack-2.2.6.3/lib/rack/server.rb:334:in `server'
2023-03-10 16:25:04     from /usr/local/bundle/gems/rack-2.2.6.3/lib/rack/server.rb:255:in `block in logging_middleware'
2023-03-10 16:25:04     from /usr/local/bundle/gems/rack-2.2.6.3/lib/rack/server.rb:413:in `block in build_app'
2023-03-10 16:25:04     from /usr/local/bundle/gems/rack-2.2.6.3/lib/rack/server.rb:412:in `reverse_each'
2023-03-10 16:25:04     from /usr/local/bundle/gems/rack-2.2.6.3/lib/rack/server.rb:412:in `build_app'
2023-03-10 16:25:04     from /usr/local/bundle/gems/rack-2.2.6.3/lib/rack/server.rb:422:in `wrapped_app'
2023-03-10 16:25:04     from /usr/local/bundle/gems/rack-2.2.6.3/lib/rack/server.rb:312:in `block in start'
2023-03-10 16:25:04     from /usr/local/bundle/gems/rack-2.2.6.3/lib/rack/server.rb:379:in `handle_profiling'
2023-03-10 16:25:04     from /usr/local/bundle/gems/rack-2.2.6.3/lib/rack/server.rb:311:in `start'
2023-03-10 16:25:04     from /usr/local/bundle/gems/rack-2.2.6.3/lib/rack

nelsnelson · 2023-03-11T03:56:51Z

I also had some trouble getting the server to run outside of docker. Installing all the dependencies in the right places was not as simple as bundle install.

This is why I relied on using docker in the master branch of the cloned project directory, instead.

nelsnelson@neptuno:~/Documents/code$ git clone git@github.com:geminabox/geminabox.git
Cloning into 'geminabox'...
remote: Enumerating objects: 3163, done.
remote: Counting objects: 100% (47/47), done.
remote: Compressing objects: 100% (34/34), done.
remote: Total 3163 (delta 23), reused 33 (delta 13), pack-reused 3116
Receiving objects: 100% (3163/3163), 607.21 KiB | 3.49 MiB/s, done.
Resolving deltas: 100% (1756/1756), done.
nelsnelson@neptuno:~/Documents/code$ cd geminabox
nelsnelson@neptuno:~/Documents/code/geminabox[master]$ docker build -t geminabox .
[+] Building 9.9s (10/10) FINISHED                                                                                                                          
 => [internal] load build definition from Dockerfile                                                                                                   0.0s
 => => transferring dockerfile: 200B                                                                                                                   0.0s
 => [internal] load .dockerignore                                                                                                                      0.0s
 => => transferring context: 2B                                                                                                                        0.0s
 => [internal] load metadata for docker.io/library/ruby:3.1.3                                                                                          0.0s
 => [1/5] FROM docker.io/library/ruby:3.1.3                                                                                                            0.0s
 => [internal] load build context                                                                                                                      0.0s
 => => transferring context: 927.76kB                                                                                                                  0.0s
 => CACHED [2/5] RUN mkdir -p /usr/src/app                                                                                                             0.0s
 => CACHED [3/5] WORKDIR /usr/src/app                                                                                                                  0.0s
 => [4/5] COPY . /usr/src/app                                                                                                                          0.0s
 => [5/5] RUN bundle install                                                                                                                           9.7s
 => exporting to image                                                                                                                                 0.2s 
 => => exporting layers                                                                                                                                0.2s 
 => => writing image sha256:4189fb024167d7f9f4f2c55dbcd01af424463ad68b4349bf4f4275d857faea5c                                                           0.0s 
 => => naming to docker.io/library/geminabox                                                                                                           0.0s 
nelsnelson@neptuno:~/Documents/code/geminabox[master]$ docker run --name geminabox --rm -d -p 9292:9292 geminabox:latest
e170ad86e857c98ccc107074ce9c707013b03cc2895fbd19f995d8c5a314c118
nelsnelson@neptuno:~/Documents/code/geminabox[master]$ curl http://localhost:9292   
<!DOCTYPE html>
<html>
  <head>
    <title>Gem in a Box</title>
    <link rel="stylesheet" href="/master.css" type="text/css" media="screen">
    <link href="/atom.xml" type="application/atom+xml" rel="alternate" title="Atom Feed">
  </head>
  <body>
    <div id="content">
      <h1>Gem in a Box</h1>
      <p>
<small>If you did not need any credentials to get to this page</small>
  <pre><code>gem sources -a http://localhost:9292/</code></pre>
<small>If you needed some credentials to get to this page</small>
  <pre><code>gem sources -a http://username:password@localhost:9292/</code></pre>
<small>and then ...</small>
  <pre><code>gem install geminabox<br />gem inabox [gemfile]</code></pre>
</p>


<a href="http://localhost:9292/upload">Upload Another Gem</a>
<script type="text/javascript" src="/master.js"></script>

    </div>
  </body>
</html>
nelsnelson@neptuno:~/Documents/code/geminabox[master]$ docker stop geminabox
geminabox
nelsnelson@neptuno:~/Documents/code/geminabox[master]$ docker ps | grep geminabox
nelsnelson@neptuno:~/Documents/code/geminabox[master]$

nelsnelson · 2023-03-11T04:04:20Z

I've updated the fork branch commit message to ensure that it includes the phrase "closes #506" but the issue still includes no reference to this PR. I'm perplexed.

[Screenshot from: https://github.com//issues/506]

pboling · 2023-03-11T07:41:23Z

Oh, lol I think it is because #506 is already closed!

Anyways, thanks for your steps. I'll try that. Would be great to get the readme into a state where a copy pasta setup is functional!

github-actions · 2023-05-11T00:53:37Z

You should update this pull request by commenting on it. Otherwise the PR will be closed in 14 days.

nelsnelson · 2023-05-11T04:53:21Z

You should update this pull request by commenting on it. Otherwise the PR will be closed in 14 days.

Is there any way that the related pull request could get accepted and this issue subsequently closed appropriately?

pboling · 2023-05-16T04:33:43Z

@tnir This fix is important. Commenting to keep the PR from going stale!

github-actions · 2023-07-16T00:54:00Z

You should update this pull request by commenting on it. Otherwise the PR will be closed in 14 days.

nelsnelson · 2023-07-16T14:54:33Z

Commenting to keep the PR from going stale.

nelsnelson · 2023-08-19T01:42:02Z

Commenting on this PR to prevent it from going stale.

closes geminabox#506 See: geminabox#506

pboling · 2023-08-26T00:17:33Z

Looks like we in for a bump every 2 months... unless @tnir can rescue us from the slog.

nelsnelson · 2023-08-26T03:58:15Z

Looks like we in for a bump every 2 months... unless @tnir can rescue us from the slog.

I wish I understood what went wrong. I thought I had linked the issue to this PR through the commit message. That worked right? Are we just waiting on the project owner to accept this PR?

nelsnelson · 2023-08-26T04:01:46Z

Looks like on Jul 16 @tnir re-opened the linked issue, so now the PR and the issue are in fact linked. Not sure what the next steps are.

github-actions · 2023-10-26T00:52:14Z

You should update this pull request by commenting on it. Otherwise the PR will be closed in 14 days.

pboling · 2023-10-26T03:37:58Z

Burp.

github-actions · 2023-12-26T00:52:18Z

You should update this pull request by commenting on it. Otherwise the PR will be closed in 14 days.

pboling · 2023-12-26T23:19:36Z

Particle accelerators.

github-actions · 2024-02-25T00:52:32Z

You should update this pull request by commenting on it. Otherwise the PR will be closed in 14 days.

pboling · 2024-02-25T06:28:14Z

Meridian lines are tedious abstractions of interstellar malfeasance.

github-actions · 2024-04-26T00:52:24Z

You should update this pull request by commenting on it. Otherwise the PR will be closed in 14 days.

nelsnelson · 2024-04-26T03:02:05Z

Bumping, please merge the linked PR.

pboling · 2024-04-27T02:17:29Z

@tnir Can we turn off the stale bot?

github-actions bot added the no-pr-activity label Mar 1, 2023

pboling approved these changes Mar 9, 2023

View reviewed changes

github-actions bot removed the no-pr-activity label Mar 10, 2023

nelsnelson mentioned this pull request Mar 10, 2023

NameError - uninitialized constant Geminabox::VERSION #506

Closed

nelsnelson force-pushed the fix-missing-version-constant branch from 79b891c to 4d34b66 Compare March 11, 2023 04:00

github-actions bot added the no-pr-activity label May 11, 2023

github-actions bot removed the no-pr-activity label May 12, 2023

github-actions bot added the no-pr-activity label Jul 16, 2023

github-actions bot removed the no-pr-activity label Jul 17, 2023

Fix Geminabox::VERSION instantiation failure

8237b6e

closes geminabox#506 See: geminabox#506

nelsnelson force-pushed the fix-missing-version-constant branch from 4d34b66 to 8237b6e Compare August 19, 2023 01:44

github-actions bot added the no-pr-activity label Oct 26, 2023

github-actions bot removed the no-pr-activity label Oct 27, 2023

github-actions bot added the no-pr-activity label Dec 26, 2023

github-actions bot removed the no-pr-activity label Dec 27, 2023

github-actions bot added the no-pr-activity label Feb 25, 2024

github-actions bot removed the no-pr-activity label Feb 26, 2024

github-actions bot added the no-pr-activity label Apr 26, 2024

github-actions bot removed the no-pr-activity label Apr 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Geminabox::VERSION instantiation failure #514

Fix Geminabox::VERSION instantiation failure #514

nelsnelson commented Dec 30, 2022

github-actions bot commented Mar 1, 2023

pboling left a comment

nelsnelson commented Mar 10, 2023

pboling commented Mar 10, 2023

pboling commented Mar 10, 2023 •

edited

pboling commented Mar 10, 2023 •

edited

nelsnelson commented Mar 11, 2023

nelsnelson commented Mar 11, 2023 •

edited

pboling commented Mar 11, 2023

github-actions bot commented May 11, 2023

nelsnelson commented May 11, 2023

pboling commented May 16, 2023

github-actions bot commented Jul 16, 2023

nelsnelson commented Jul 16, 2023

nelsnelson commented Aug 19, 2023

pboling commented Aug 26, 2023

nelsnelson commented Aug 26, 2023

nelsnelson commented Aug 26, 2023

github-actions bot commented Oct 26, 2023

pboling commented Oct 26, 2023

github-actions bot commented Dec 26, 2023

pboling commented Dec 26, 2023

github-actions bot commented Feb 25, 2024

pboling commented Feb 25, 2024

github-actions bot commented Apr 26, 2024

nelsnelson commented Apr 26, 2024

pboling commented Apr 27, 2024

Fix Geminabox::VERSION instantiation failure #514

Are you sure you want to change the base?

Fix Geminabox::VERSION instantiation failure #514

Conversation

nelsnelson commented Dec 30, 2022

github-actions bot commented Mar 1, 2023

pboling left a comment

Choose a reason for hiding this comment

nelsnelson commented Mar 10, 2023

pboling commented Mar 10, 2023

pboling commented Mar 10, 2023 • edited

pboling commented Mar 10, 2023 • edited

nelsnelson commented Mar 11, 2023

nelsnelson commented Mar 11, 2023 • edited

pboling commented Mar 11, 2023

github-actions bot commented May 11, 2023

nelsnelson commented May 11, 2023

pboling commented May 16, 2023

github-actions bot commented Jul 16, 2023

nelsnelson commented Jul 16, 2023

nelsnelson commented Aug 19, 2023

pboling commented Aug 26, 2023

nelsnelson commented Aug 26, 2023

nelsnelson commented Aug 26, 2023

github-actions bot commented Oct 26, 2023

pboling commented Oct 26, 2023

github-actions bot commented Dec 26, 2023

pboling commented Dec 26, 2023

github-actions bot commented Feb 25, 2024

pboling commented Feb 25, 2024

github-actions bot commented Apr 26, 2024

nelsnelson commented Apr 26, 2024

pboling commented Apr 27, 2024

pboling commented Mar 10, 2023 •

edited

pboling commented Mar 10, 2023 •

edited

nelsnelson commented Mar 11, 2023 •

edited