New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip support #36
base: master
Are you sure you want to change the base?
Pip support #36
Conversation
Would you mind splitting this into two PR's? one for the pip setup addition and the other rebased against master? I merged a previous PR that already cleaned up PEP8 violations and py2/3 support. Thanks!!! My pypi username is also "gelstudios". |
@@ -98,7 +98,7 @@ | |||
[1,0,1,0,1,0,1,0,0,0,1,1,1,0,0,1,0,1,0,1,0,1,1,1]] | |||
|
|||
ASCII_TO_NUMBER = { | |||
'_': 0, | |||
'-': 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, well spotted!
That should explain why I had to replace 1s with 0s in e7e6783!
Please rebase and adjust the NUMBERS
two-dimensional list in the test so that it contains 1s instead of 0s again like the original ONEUP
value (that should make the test pass again).
Thanks for creating the setup script! Feel free to provide that in a separate PR. |
Had to move gitfiti.py into a module for the entrypoint to work correctly Also added setup.py for pip support
updated. This is now just mostly pip support |
@gelstudios you are now an owner of the package. Feel free to remove me if youd like. |
You might want to add a Trove classifier for Python 3.4 as well. Thanks for introducing a package, was going to do that later, too. This makes it easier to deconstruct code into several modules. I assume the test for |
ok fixed test and added the classifier |
This pull request does the following things:
You can upload to pip using
./setup.py sdist upload
. In order to upload, you will need to change the version__version__
in gitfiti.py. You may want to take the liberty of editing some things in setup.pyI have taken the privileged of uploading this to pypi already. If you send me your pypi username I will pass ownership to you.
The readme will have to be updated to show you can install with pip