Fix https://github.com/geerlingguy/ansible-role-varnish/issues/116 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilge
reviewed
Oct 23, 2023
Co-authored-by: Bilge <bilge@scriptfusion.com>
Bilge
reviewed
Oct 25, 2023
| @@ -46,4 +46,4 @@ | |||
| yum: | |||
| name: "{{ varnish_modules_package_name }}" | |||
| state: present | |||
| when: varnish_modules_package_name | |||
| when: varnish_modules_package_name is defined and varnish_modules_package_name|length > 0 | |||
There was a problem hiding this comment.
Presumably this condition should match the other?
|
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
|
Marking PRs as stale with absolutely no input from the maintainer? Now that's fucked up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although not reproducable at least with Ansible 2.14 this should fix #116