Fix mysql tasks when using custom socket #351
Conversation
Update all tasks interacting with the MySQL db on the system to use the configured socket. Otherwise setting the mysql_socket variable to something different from the default will result in errors since the tasks can not connect to the db.
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark pull requests as stale. |
|
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details. |
|
Can we do better here? There have been at least 4 separate PRs (#312, #351, #358 & #366) that I can see that attempt to fix this issue. Or specifically, ansible/ansible#47736 . Being busy is perfectly fine, but if stalebot is closing things faster than you can triage/merge them, it needs to be reconfigured or removed. I'm pretty sure this is the cleanest one, and as I understand it the CI should work now that the Debian 10 default changes have been merged. My specific issue here is the change in behaviour that's brought about by using pymysql as opposed to mysqldb - it no longer defaults to using the socket. |
Update all tasks interacting with the MySQL db on the system to use the
configured socket. Otherwise setting the mysql_socket variable to
something different from the default will result in errors since the
tasks can not connect to the db.