Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge: LaamimAyoub submission #81

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LaamimAyoub
Copy link

No description provided.

Comment on lines 39 to 40
with open(self.input_path, "r") as fh:
txt = fh.read()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading all of the file will just cause your solution to OOM, please fix.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. thank you.

@LaamimAyoub LaamimAyoub reopened this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants