Update Python Program to Sort Words in Alphabetic Order.py #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .sort() function sorts strings by ASCII Code. The original code did not return all words alphabetically. I added a .lower() function to make sure all words were the same case that way they would return alphabetically.
NitkarshChourasia
suggested changes
May 7, 2024
There was a problem hiding this comment.
It is good.
But can be made much better.
By making sure the cases of the letters stays consistent, and not every letter become lowercase (or uppercase if you try to do that in next commit. Please refrain from that).
Best regards,
@NitkarshChourasia
| my_str = "Hello this Is an Example With cased letters" | ||
| word_Dict = {} |
There was a problem hiding this comment.
Why this dictionary is used for no reason at all?
| my_str = "Hello this Is an Example With cased letters" | ||
| word_Dict = {} | ||
| count = 0 |
There was a problem hiding this comment.
Why this variable count is used for no reason of it being anywhere in the program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .sort() function sorts strings by ASCII Code. The original code did not return all words alphabetically. I added a .lower() function to make sure all words were the same case that way they would return alphabetically.